Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: update to coder/quartz v0.2.0#18007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 3 commits intomainfromspike/update-quartz-0.2.0
May 27, 2025

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedMay 23, 2025
edited
Loading

Upgrade to coder/quartz v0.2.0 including fixing up a minor API breaking change.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewMay 23, 2025 12:52
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@mafredri
Copy link
Member

mafredri commentedMay 24, 2025
edited
Loading

panic: Log in goroutine after TestRotator/NoKeysOnInit has completed: Mock Clock - TickerFunc(<ctx>, 10m0s, <fn>, []) call, matched 0 traps

https://github.com/coder/coder/actions/runs/15210729290/job/42784023673?pr=18007#step:10:724

Perhaps quartz should register at.Cleanup and guard against usingt afterwards?

@spikecurtisGraphite App
Copy link
ContributorAuthor

@mafredri what do you think of pointingcoder/coder at the tip ofcoder/quartz for like a week, then tagging Quartz v0.2.1 after we verify that we're not seeing racy issues like the one above. Should hopefully ensure we don't have more churn on the Quartz releases than we already are going to.

@mafredri
Copy link
Member

@mafredri what do you think of pointingcoder/coder at the tip ofcoder/quartz for like a week, then tagging Quartz v0.2.1 after we verify that we're not seeing racy issues like the one above. Should hopefully ensure we don't have more churn on the Quartz releases than we already are going to.

Sounds good to me 👍🏻

@spikecurtisspikecurtis changed the titlechore: updated to coder/quartz v0.2.0chore: update to coder/quartz v0.2.0May 27, 2025
@spikecurtisspikecurtisforce-pushed thespike/update-quartz-0.2.0 branch from4716462 toe55fde0CompareMay 27, 2025 11:50
@spikecurtisspikecurtis merged commit6c0bed0 intomainMay 27, 2025
31 checks passed
@spikecurtisGraphite App
Copy link
ContributorAuthor

Merge activity

@spikecurtisspikecurtis deleted the spike/update-quartz-0.2.0 branchMay 27, 2025 12:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mafredrimafredrimafredri approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@mafredri

[8]ページ先頭

©2009-2025 Movatter.jp