Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create experimental template embed page for dynamic params#17999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 10 commits intomainfromjaaydenh/template-embed-page
Jun 23, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedMay 22, 2025•
edited
Loading

@jaaydenhjaaydenh self-assigned thisMay 22, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelMay 30, 2025
@jaaydenhjaaydenh reopened thisJun 2, 2025
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJun 3, 2025
@github-actionsgithub-actionsbot added the staleThis issue is like stale bread. labelJun 11, 2025
@jaaydenhjaaydenh reopened thisJun 15, 2025
@github-actionsgithub-actionsbot removed the staleThis issue is like stale bread. labelJun 16, 2025
@jaaydenhjaaydenhforce-pushed thejaaydenh/template-embed-page branch from7c28011 to71d0a19CompareJune 18, 2025 17:47
@jaaydenhjaaydenh marked this pull request as ready for reviewJune 20, 2025 16:35
@jaaydenhjaaydenhforce-pushed thejaaydenh/template-embed-page branch from97fe2be toe9671b9CompareJune 23, 2025 17:21
@jaaydenhjaaydenh requested a review fromaslilacJune 23, 2025 17:22
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@BrunoQuaresma might have more context/thoughts on this page than me if you have time to get a review from him, but it all looks reasonable to me

if (parameters) {
const serverParamValues: Record<string, string> = {};
for (const p of parameters) {
const initialVal = p.value?.valid ? p.value.value : "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
constinitialVal=p.value?.valid ?p.value.value :"";
constinitialVal=p.value?.valid??"";

more question marks in exchange for being slightly terser 🤷‍♀️

jaaydenh reacted with thumbs up emoji
@jaaydenhjaaydenh merged commit6877142 intomainJun 23, 2025
33 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/template-embed-page branchJune 23, 2025 19:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsJun 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UpdateTemplateEmbedPage for Parameters
2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp