- Notifications
You must be signed in to change notification settings - Fork911
refactor: refactor activity in workspace page#17980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| case "failure": | ||
| returntheme.palette.error.main; | ||
| return"text-content-warning"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
should this be text-content-destructive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure. I use warning for "alerts" and destructive for "actions". Eg. A failure is just warning the user about an error, but delete, is an action that destroy things. Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I guess it depends on the context and the feature, I have been using destructive for error alerts and warning for warning alerts because sometimes there are both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall this is an improvement for the UI and nice to see updates to use Tailwind.
I am guessing that this was originally placed closer to the top of the page originally for demo purposes but the current location feels more useful if you wanted to review many logs at once.
6f0defb intomainUh oh!
There was an error while loading.Please reload this page.
Changing the activity in the workspace page. It is more boring, but more reliable and extensible. By moving it to the bottom of the agent card, we have more space to display longer messages and more items. It also give us some space for interactivity controls in case we want them in the future.
Before:
After:
Screen.Recording.2025-05-21.at.19.10.32.mov