- Notifications
You must be signed in to change notification settings - Fork1k
docs: update deployment.go feature stages and script to reflect current stages#17975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…tead of ExperimentsAll
We probably shouldn't be suggesting `ignore_changes = all`. Only theattributes which cause drift in prebuilds should be ignored; everythingelse can behave as normal.---------Signed-off-by: Danny Kopping <dannykopping@gmail.com>Co-authored-by: Edward Angert <EdwardAngert@users.noreply.github.com>
1. ExpandMoreOutlined → ChevronDownIcon2. Error/ErrorIcon → CircleAlertIcon3. CheckCircle → CircleCheckIcon4. Warning → TriangleAlertIcon
fixescoder/internal#627Adds docs for `coder://` URLs for Windows Remote Desktop (RDP).Note that we might want to hold of merging since the URI handling isunreleased in Coder Desktop for Windows.
Fixes flake seen here:https://github.com/coder/coder/actions/runs/15154327939/job/42606133069?pr=17960Error log dropped when the dRPC server is being shut down right as we are (re)dialing.
This PR refactors the CompleteJob function to use database transactionsmore consistently for better atomicity guarantees. The large functionwas broken down into three specialized handlers:- completeTemplateImportJob- completeWorkspaceBuildJob- completeTemplateDryRunJobEach handler now uses the Database.InTx wrapper to ensure all databaseoperations for a job completion are performed within a singletransaction, preventing partial updates in case of failures.Added comprehensive tests for transaction behavior for each job type.Fixes#17694🤖 Generated with [Claude Code](https://claude.ai/code)Co-authored-by: Claude <noreply@anthropic.com>
Prefer to show the top level diagnostics inside the parameters sectionfor context but this adds a case to show diagnostics if there are noparameters.Normally, the entire parameters section is hidden if there are noparameters.
- Add featurestages.go with FeatureRegistry containing early access and beta features- Update docs_update_experiments.sh to extract feature information from featurestages.go- Update feature-stages.md with sections for early access and beta features🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Fix script to use single-pass awk processing- Fix typo in feature-stages.md- Simplify script by removing temporary files🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
- Add FeatureStage type and constants in deployment.go- Add GetStage, GetDescription, and GetDocsPath methods to Experiment- Remove featurestages.go in favor of deployment.go- Update docs_update_experiments.sh to extract features from deployment.go- Add ExperimentDevContainers to ExperimentsSafe🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
github-actionsbot commentedMay 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I have read the CLA Document and I hereby sign the CLA 2 out of3 committers have signed the CLA. |
Instead of showing a "yellow question icon" on the side of the status,to let the user aware of unhealthy agents, we could make it yellow anduse a tooltip.Before:<img width="1512" alt="Screenshot 2025-05-20 at 18 13 15"src="https://github.com/user-attachments/assets/afee470e-9dd4-4c32-b2bc-b9f66eac60fa"/>After:<img width="1512" alt="Screenshot 2025-05-20 at 18 13 26"src="https://github.com/user-attachments/assets/5769828b-f23c-45a5-8017-c4a88f085d0f"/>
Replaced MUI Button with custom Button in 5 components: - Filter.tsx - Changed import and updated Button props(variant="outline", size="sm") - ChatLayout.tsx - Changed import and updated Buttonprops for the "New Chat" button - StarterTemplatePageView.tsx - Changed import andimplemented asChild pattern for links - Notifications.tsx - Changed import and updatedNotificationActionButton to use variant="subtle" - DateRange.tsx - Changed import and updated Buttonstyling
1. PersonOutline → UserIcon2. Apps → LayoutGridIcon3. Delete → TrashIcon4. InsertDriveFile → FileIcon
Relates to#17432### Part 1:Notes:- `GetPresetsAtFailureLimit` SQL query is added, which is similar to`GetPresetsBackoff`, they use same CTEs: `filtered_builds`,`time_sorted_builds`, but they are still different.- Query is executed on every loop iteration. We can consider markingspecific preset as permanently failed as an optimization to avoidexecuting query on every loop iteration. But I decided don't do it fornow.- By default `FailureHardLimit` is set to 3.- `FailureHardLimit` is configurable. Setting it to zero - means thathard limit is disabled.### Part 2Notes:- `PrebuildFailureLimitReached` notification is added.- Notification is sent to template admins.- Notification is sent only the first time, when hard limit is reached.But it will `log.Warn` on every loop iteration.- I introduced this enum:```sqlCREATE TYPE prebuild_status AS ENUM ( 'normal', -- Prebuilds are working as expected; this is the default, healthy state. 'hard_limited', -- Prebuilds have failed repeatedly and hit the configured hard failure limit; won't be retried anymore. 'validation_failed' -- Prebuilds failed due to a non-retryable validation error (e.g. template misconfiguration); won't be retried.);````validation_failed` not used in this PR, but I think it will be used innext one, so I wanted to save us an extra migration.- Notification looks like this:<img width="472" alt="image"src="https://github.com/user-attachments/assets/e10efea0-1790-4e7f-a65c-f94c40fced27"/>### Latest notification views:<img width="463" alt="image"src="https://github.com/user-attachments/assets/11310c58-68d1-4075-a497-f76d854633fe"/><img width="725" alt="image"src="https://github.com/user-attachments/assets/6bbfe21a-91ac-47c3-a9d1-21807bb0c53a"/>
codersdk/deployment.go Outdated
func (eExperiment)GetDocsPath()string { | ||
switche { | ||
caseExperimentDevContainers: | ||
return"ai-coder/dev-containers.md" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this isn't a real file
EdwardAngertMay 21, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks@aslilac
🫨 I was trying toremove not add this whole section
let me put this back in draft until claude and I work out our differences
- Improve docs_update_experiments.sh to handle GitHub authentication issues gracefully- Simplify script to avoid Go module replacement issues- Update feature-stages.md with proper categorization of features- Show feature availability in main, mainline, and stable versions
Uh oh!
There was an error while loading.Please reload this page.
adds to#17954
preview
This PR enhances how we manage feature stages and improves automatic documentation generation. It builds on the autoversion-fixes branch by centralizing feature metadata in one place.
What this brings to the autoversion-fixes branch
Key Changes