- Notifications
You must be signed in to change notification settings - Fork907
fix: skip TestReinitializeAgent until we can adapt it for windows#17968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ship it
| @@ -89,6 +90,12 @@ func TestReinitializeAgent(t *testing.T) { | |||
| t.Skip("dbmem cannot currently claim a workspace") | |||
| } | |||
| if runtime.GOOS == "windows" { | |||
| t.Skip("test startup script is not supported on windows") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: link the GH issue here
Can we ship this? This issue is causing CI failure every morning. |
1e1e6f3 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
relates tocoder/internal#642
I've reached a timebox trying to get a script for windows to work, so I'm skipping it for now.