- Notifications
You must be signed in to change notification settings - Fork913
chore: replace MUI icons with Lucide icons - update 18#17958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,20 @@ | ||
import type { Theme } from "@emotion/react"; | ||
import { useTheme } from "@emotion/react"; | ||
import CircularProgress from "@mui/material/CircularProgress"; | ||
import type { | ||
WorkspaceAppStatus as APIWorkspaceAppStatus, | ||
Workspace, | ||
WorkspaceAgent, | ||
WorkspaceApp, | ||
} from "api/typesGenerated"; | ||
import { | ||
CircleAlertIcon, | ||
CircleCheckIcon, | ||
ExternalLinkIcon, | ||
FileIcon, | ||
LayoutGridIcon, | ||
TriangleAlertIcon, | ||
} from "lucide-react"; | ||
import { useAppLink } from "modules/apps/useAppLink"; | ||
import type { FC } from "react"; | ||
@@ -163,11 +165,11 @@ export const WorkspaceAppStatus = ({ | ||
...commonStyles, | ||
}} | ||
> | ||
<FileIcon | ||
className="size-icon-xs" | ||
css={{ | ||
opacity: 0.5, | ||
marginRight: "0.25rem", | ||
Comment on lines +168 to +172 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Genuine question: Is there a reason why this wasn't switched over to Tailwind syntax? I know some of the icon libraries can be a little finicky with styling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Actually, wait, does this work as intended? I know that when you give a component a | ||
}} | ||
/> | ||
<span>{formatURI(status.uri)}</span> | ||
@@ -262,9 +264,9 @@ const AppLink: FC<AppLinkProps> = ({ app, workspace, agent }) => { | ||
}} | ||
/> | ||
) : ( | ||
<LayoutGridIcon | ||
className="size-icon-xs" | ||
css={{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Another potential area where | ||
opacity: 0.7, | ||
}} | ||
/> | ||
Uh oh!
There was an error while loading.Please reload this page.