- Notifications
You must be signed in to change notification settings - Fork909
chore: replace MUI Button - 3#17955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| <Button asChild size="sm"> | ||
| <Link to={`/templates/new?exampleId=${starterTemplate.id}`}> | ||
| <PlusIcon /> | ||
| Use template | ||
| </Link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nit: I think differentiating these two buttons with outline/default variants is the right call, but theUse template button's left padding with the icon's whitespace is large, so the button contents look unbalanced
main:
this branch:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure if I got it.... 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No big deal haha. Being thatButton has equalpx on the left/right, I feel like adding unequal x-padding like this inButton variants (or case-by-case for each icon?) would be a bit of a pain
f35a1bc intomainUh oh!
There was an error while loading.Please reload this page.
Replaced MUI Button with custom Button in 5 components:
(variant="outline", size="sm")
props for the "New Chat" button
implemented asChild pattern for links
NotificationActionButton to use variant="subtle"
styling