Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: replace MUI Button - 3#17955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/replace-mui-button-3-main
May 21, 2025
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Replaced MUI Button with custom Button in 5 components:

  • Filter.tsx - Changed import and updated Button props
    (variant="outline", size="sm")
  • ChatLayout.tsx - Changed import and updated Button
    props for the "New Chat" button
  • StarterTemplatePageView.tsx - Changed import and
    implemented asChild pattern for links
  • Notifications.tsx - Changed import and updated
    NotificationActionButton to use variant="subtle"
  • DateRange.tsx - Changed import and updated Button
    styling

@BrunoQuaresmaBrunoQuaresma requested a review froma teamMay 20, 2025 20:40
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 20, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromaqandrew and removed request fora teamMay 20, 2025 20:40
Comment on lines +53 to +57
<Button asChild size="sm">
<Link to={`/templates/new?exampleId=${starterTemplate.id}`}>
<PlusIcon />
Use template
</Link>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nit: I think differentiating these two buttons with outline/default variants is the right call, but theUse template button's left padding with the icon's whitespace is large, so the button contents look unbalanced

main:

image

this branch:

image

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure if I got it.... 🤔

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Screenshot 2025-05-21 at 12 12 48 PM

No big deal haha. Being thatButton has equalpx on the left/right, I feel like adding unequal x-padding like this inButton variants (or case-by-case for each icon?) would be a bit of a pain

@BrunoQuaresmaBrunoQuaresma merged commitf35a1bc intomainMay 21, 2025
34 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/replace-mui-button-3-main branchMay 21, 2025 18:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aqandrewaqandrewaqandrew approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@BrunoQuaresma@aqandrew

[8]ページ先頭

©2009-2025 Movatter.jp