Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: add form_type parameter argument to db#17920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 61 commits intomainfromstevenmasley/param_form_type
May 29, 2025
Merged
Changes from1 commit
Commits
Show all changes
61 commits
Select commitHold shift + click to select a range
af8bead
chore: initial migration
EmyrkMay 19, 2025
a65f276
make gen
EmyrkMay 19, 2025
9996c8c
update insert query
EmyrkMay 19, 2025
feaeef7
make gen
EmyrkMay 19, 2025
25d04ad
update provisioenrsdk
EmyrkMay 19, 2025
0317037
make gen
EmyrkMay 19, 2025
a28c610
passing form_type to coderd
EmyrkMay 19, 2025
49b8035
feat: form_type plumbing and validation for multi select
EmyrkMay 19, 2025
0f3d557
update terraform dep for struct tags
EmyrkMay 19, 2025
1a9e711
remove dead comments
EmyrkMay 19, 2025
c317769
add unit test for 'inOptionSet'
EmyrkMay 19, 2025
c11a3c4
chore: add unit test for improper multi-select
EmyrkMay 19, 2025
bc83309
make gen
EmyrkMay 19, 2025
108ad42
make fmt
EmyrkMay 19, 2025
383b64f
Merge branch 'main' into stevenmasley/param_form_type
EmyrkMay 19, 2025
0325364
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 21, 2025
2560400
create form_type enum in db
EmyrkMay 21, 2025
b630365
chore: check enum value before insert
EmyrkMay 21, 2025
b8e121a
compile fix
EmyrkMay 21, 2025
c271424
delete duplicate converter
EmyrkMay 21, 2025
ea5c4b8
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 21, 2025
827ae32
migration bump
EmyrkMay 21, 2025
8beade9
make gen
EmyrkMay 21, 2025
5d9ccb6
linting
EmyrkMay 21, 2025
6de1b01
fixup entities
EmyrkMay 21, 2025
44c53ff
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 22, 2025
85acc1f
test for bad form_type
EmyrkMay 22, 2025
2200db7
handle null options
EmyrkMay 22, 2025
77d65cb
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 22, 2025
940b7aa
init nil slice
EmyrkMay 22, 2025
1ff7012
make form_type an enum in the proto
EmyrkMay 23, 2025
856ccaa
make gen
EmyrkMay 23, 2025
ce07f00
add proto enum converters
EmyrkMay 23, 2025
aa46cab
add db validation
EmyrkMay 23, 2025
ad362e0
rename error enum
EmyrkMay 23, 2025
33c3bde
compile fix
EmyrkMay 23, 2025
9c1d812
compile fix on test
EmyrkMay 23, 2025
be9d88e
make gen
EmyrkMay 23, 2025
a3d8446
handle error type
EmyrkMay 23, 2025
8229966
fixups
EmyrkMay 23, 2025
24f2e05
linting
EmyrkMay 23, 2025
3c687e4
text fixup
EmyrkMay 23, 2025
f52e789
fixup comment
EmyrkMay 27, 2025
8ada165
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 27, 2025
6fabc27
try to resolve some gen issues
EmyrkMay 27, 2025
0dc98e4
make gen
EmyrkMay 27, 2025
c74baef
fixup test asserts
EmyrkMay 27, 2025
cedf39f
more explicit form type in unit test
EmyrkMay 27, 2025
6e9beed
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 27, 2025
3c97ec7
bump migration
EmyrkMay 27, 2025
becfd7c
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 27, 2025
deaff2a
make gen
EmyrkMay 27, 2025
cab124a
bump migration
EmyrkMay 27, 2025
1388d27
add enums struct tag to FormType
EmyrkMay 28, 2025
716200f
spaces over tabs
EmyrkMay 28, 2025
2e9723b
make inOptionSet more strict
EmyrkMay 28, 2025
9d52e48
make gen
EmyrkMay 28, 2025
f012e51
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 28, 2025
ba70555
migration bump
EmyrkMay 28, 2025
1876d03
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
EmyrkMay 29, 2025
c1187e6
ci redo
EmyrkMay 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
more explicit form type in unit test
  • Loading branch information
@Emyrk
Emyrk committedMay 27, 2025
commitcedf39ff37e1a2a3e87c4733df27d4d5d8b0d7fe
2 changes: 2 additions & 0 deletionscoderd/workspaces_test.go
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to see a test here for the kind of build inputs that could trigger the new error path in codersdk added below.

Copy link
MemberAuthor

@EmyrkEmyrkMay 19, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The previous code was stricter (not allowing multi-select).

So the new code allows more inputs, rather than removing.

But I will hit the new error path 👍

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

AddedTestWorkspaceWithMultiSelectFailure

Original file line numberDiff line numberDiff line change
Expand Up@@ -3549,6 +3549,7 @@ func TestWorkspaceWithRichParameters(t *testing.T) {
Name: firstParameterName,
Type: firstParameterType,
Description: firstParameterDescription,
FormType: proto.ParameterFormType_INPUT,
},
{
Name: secondParameterName,
Expand All@@ -3558,6 +3559,7 @@ func TestWorkspaceWithRichParameters(t *testing.T) {
ValidationMin: ptr.Ref(int32(1)),
ValidationMax: ptr.Ref(int32(3)),
ValidationMonotonic: string(secondParameterValidationMonotonic),
FormType: proto.ParameterFormType_INPUT,
},
{
Name: thirdParameterName,
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp