- Notifications
You must be signed in to change notification settings - Fork929
chore: add form_type parameter argument to db#17920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
61 commits Select commitHold shift + click to select a range
af8bead
chore: initial migration
Emyrka65f276
make gen
Emyrk9996c8c
update insert query
Emyrkfeaeef7
make gen
Emyrk25d04ad
update provisioenrsdk
Emyrk0317037
make gen
Emyrka28c610
passing form_type to coderd
Emyrk49b8035
feat: form_type plumbing and validation for multi select
Emyrk0f3d557
update terraform dep for struct tags
Emyrk1a9e711
remove dead comments
Emyrkc317769
add unit test for 'inOptionSet'
Emyrkc11a3c4
chore: add unit test for improper multi-select
Emyrkbc83309
make gen
Emyrk108ad42
make fmt
Emyrk383b64f
Merge branch 'main' into stevenmasley/param_form_type
Emyrk0325364
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk2560400
create form_type enum in db
Emyrkb630365
chore: check enum value before insert
Emyrkb8e121a
compile fix
Emyrkc271424
delete duplicate converter
Emyrkea5c4b8
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk827ae32
migration bump
Emyrk8beade9
make gen
Emyrk5d9ccb6
linting
Emyrk6de1b01
fixup entities
Emyrk44c53ff
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk85acc1f
test for bad form_type
Emyrk2200db7
handle null options
Emyrk77d65cb
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk940b7aa
init nil slice
Emyrk1ff7012
make form_type an enum in the proto
Emyrk856ccaa
make gen
Emyrkce07f00
add proto enum converters
Emyrkaa46cab
add db validation
Emyrkad362e0
rename error enum
Emyrk33c3bde
compile fix
Emyrk9c1d812
compile fix on test
Emyrkbe9d88e
make gen
Emyrka3d8446
handle error type
Emyrk8229966
fixups
Emyrk24f2e05
linting
Emyrk3c687e4
text fixup
Emyrkf52e789
fixup comment
Emyrk8ada165
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk6fabc27
try to resolve some gen issues
Emyrk0dc98e4
make gen
Emyrkc74baef
fixup test asserts
Emyrkcedf39f
more explicit form type in unit test
Emyrk6e9beed
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrk3c97ec7
bump migration
Emyrkbecfd7c
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrkdeaff2a
make gen
Emyrkcab124a
bump migration
Emyrk1388d27
add enums struct tag to FormType
Emyrk716200f
spaces over tabs
Emyrk2e9723b
make inOptionSet more strict
Emyrk9d52e48
make gen
Emyrkf012e51
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrkba70555
migration bump
Emyrk1876d03
Merge remote-tracking branch 'origin/main' into stevenmasley/param_fo…
Emyrkc1187e6
ci redo
EmyrkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
chore: initial migration
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitaf8bead3890738dfa6cbdf1328ede3f7a077e4e5
There are no files selected for viewing
1 change: 1 addition & 0 deletionscoderd/database/migrations/000328_parameter_form_type.down.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
ALTER TABLE template_version_parameters DROP COLUMN form_type; |
6 changes: 6 additions & 0 deletionscoderd/database/migrations/000328_parameter_form_type.up.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
-- Intentionally leaving the default blank. The provisioner will not re-run any | ||
-- imports to backfill these values. Missing values just have to be handled. | ||
ALTER TABLE template_version_parameters ADD COLUMN form_type text NOT NULL DEFAULT ''; | ||
COMMENT ON COLUMN template_version_parameters.form_type | ||
IS 'Specify what form_type should be used to render the parameter in the UI. This value should correspond to an enum, but this will not be enforced in the sql. Mistakes here should not be fatal for functional usage.'; |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.