Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: update cli auth page design#17915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 2 commits intomainfrombq/fix-copy-session-token
May 19, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedMay 19, 2025
edited
Loading

Improve UX of CLI Auth page.

Before:

Screenshot 2025-05-19 at 09 22 36

After:

Screen.Recording.2025-05-19.at.09.20.18.mov

Fixes#17905

matifali reacted with heart emoji
@BrunoQuaresmaBrunoQuaresma requested review fromethanndickson anda teamMay 19, 2025 12:22
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 19, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromParkreiner and removed request fora teamMay 19, 2025 12:22
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! Definitely an improvement over the original. Deferring approval to someone more familiar with the frontend.

BrunoQuaresma and matifali reacted with heart emoji
Copy link
Member

@ParkreinerParkreiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Appreciate you making these changes!

*/}
<span css={{ ...visuallyHidden }}>{VISUALLY_HIDDEN_SPACE}</span>
<p className="m-0 text-center text-sm text-content-secondary leading-normal">
Copy the session token below and{" "}
<strong css={{ display: "block" }}>paste it in your terminal.</strong>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh, this can be swapped over to Tailwind, too:className="block"

BrunoQuaresma reacted with thumbs up emoji
@BrunoQuaresmaBrunoQuaresma merged commitca5f114 intomainMay 19, 2025
34 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-copy-session-token branchMay 19, 2025 16:28
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson left review comments

@ParkreinerParkreinerParkreiner approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking/cli-auth button does not copy session token
3 participants
@BrunoQuaresma@Parkreiner@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp