- Notifications
You must be signed in to change notification settings - Fork1k
fix(dogfood/coder): stop docker containers and prune system on shutdown#17904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hopefully the final update to thne fix in#17110This change greatly speeds up workspace destruction:```2025-05-19 12:26:57.046+03:00 docker_container.workspace[0]: Destroying... [id=2685e2f456ba7b280c420219f19ef15384faa52c61ba7c087c7f109ffa6b1bda]2025-05-19 12:27:07.046+03:00 docker_container.workspace[0]: Still destroying... [10s elapsed]2025-05-19 12:27:16.734+03:00 docker_container.workspace[0]: Destruction complete after 20s```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
While I think the change is worth a shot, my only concern is that someone will attempt to use this template outside of our infrastructure and get an unwelcome surprise.
Do you think it's likely? It wouldn't be my first guess, it depends on external docker hosts and has Coder specific parameters, but 🤷🏻♂️. They would also need to change the template to use a volume for |
@johnstcn added some more color to the comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the addition of a comment is sufficient here.
3dbd424
intomainUh oh!
There was an error while loading.Please reload this page.
Hopefully the final update to thne fix in#17110
This change greatly speeds up workspace destruction: