Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(dogfood/coder): stop docker containers and prune system on shutdown#17904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 3 commits intomainfrommafredri/fix-dogfood-docker-cleanup
May 19, 2025

Conversation

mafredri
Copy link
Member

Hopefully the final update to thne fix in#17110

This change greatly speeds up workspace destruction:

2025-05-19 12:26:57.046+03:00 docker_container.workspace[0]: Destroying... [id=2685e2f456ba7b280c420219f19ef15384faa52c61ba7c087c7f109ffa6b1bda]2025-05-19 12:27:07.046+03:00 docker_container.workspace[0]: Still destroying... [10s elapsed]2025-05-19 12:27:16.734+03:00 docker_container.workspace[0]: Destruction complete after 20s

Hopefully the final update to thne fix in#17110This change greatly speeds up workspace destruction:```2025-05-19 12:26:57.046+03:00 docker_container.workspace[0]: Destroying... [id=2685e2f456ba7b280c420219f19ef15384faa52c61ba7c087c7f109ffa6b1bda]2025-05-19 12:27:07.046+03:00 docker_container.workspace[0]: Still destroying... [10s elapsed]2025-05-19 12:27:16.734+03:00 docker_container.workspace[0]: Destruction complete after 20s```
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While I think the change is worth a shot, my only concern is that someone will attempt to use this template outside of our infrastructure and get an unwelcome surprise.

@mafredri
Copy link
MemberAuthor

While I think the change is worth a shot, my only concern is that someone will attempt to use this template outside of our infrastructure and get an unwelcome surprise.

Do you think it's likely? It wouldn't be my first guess, it depends on external docker hosts and has Coder specific parameters, but 🤷🏻‍♂️. They would also need to change the template to use a volume for/var/lib/docker, otherwise the containers and images would be wiped anyway (including volumes).

@mafredri
Copy link
MemberAuthor

@johnstcn added some more color to the comment.

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think the addition of a comment is sufficient here.

mafredri reacted with thumbs up emoji
@mafredrimafredri merged commit3dbd424 intomainMay 19, 2025
28 checks passed
@mafredrimafredri deleted the mafredri/fix-dogfood-docker-cleanup branchMay 19, 2025 10:23
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 19, 2025
@mafredrimafredri changed the titlefix(dogfood/coder): run docker system prune on shutdownfix(dogfood/coder): stop docker containers and prune system on shutdownMay 19, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@deansheatherdeansheatherdeansheather approved these changes

@DanielleMaywoodDanielleMaywoodAwaiting requested review from DanielleMaywood

Assignees

@mafredrimafredri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mafredri@johnstcn@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp