- Notifications
You must be signed in to change notification settings - Fork905
test: fix a race in TestReinit#17902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| cancel, err = p.Pubsub.Subscribe(event, listener) | ||
| p.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it not make more sense to move the subscribe call after we lock the spy's mutex?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think so; the mutex is protecting theexpectedEvent andtriedToSubscribe, not the underlying pubsub.
c775ea8 intomainUh oh!
There was an error while loading.Please reload this page.
closescoder/internal#632
pubsubReinitSpyused to signal that a subscription had happened before it actually had.This created a slight opportunity for the main goroutine to publish before the actual subscription was listening. The published event was then dropped, leading to a failed test.