- Notifications
You must be signed in to change notification settings - Fork906
feat: add Organization Provisioner Keys view#17889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR introduces a new Organization Provisioner Keys view feature to enable management of provisioner keys within the site. Key changes include:
- Exporting the MockProvisionerKey constant for test support.
- Adding lazy-loaded routes for the ProvisionerKeysPage in the router.
- Implementing view components, including a new table row component, page view, and corresponding Storybook stories.
- Updating API queries and sidebar navigation to integrate the new view.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/testHelpers/entities.ts | Exported MockProvisionerKey for broader test utility |
| site/src/router.tsx | Added lazy-loaded route and navigation entry for ProvisionerKeysPage |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/ProvisionerKeyRow.tsx | Introduced a new table row component for provisioner keys |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.tsx | Implemented the view component for managing provisioner keys |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.stories.tsx | Added Storybook stories for different page states |
| site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPage.tsx | Created the page component, including data fetching and permission checks |
| site/src/modules/management/OrganizationSidebarView.tsx | Updated sidebar navigation to include the Provisioner Keys link |
| site/src/api/queries/organizations.ts | Exported provisionerDaemonGroups for use in the new page view |
...nizationSettingsPage/OrganizationProvisionerKeysPage/OrganizationProvisionerKeysPageView.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
site/src/pages/OrganizationSettingsPage/OrganizationProvisionerKeysPage/ProvisionerKeyRow.tsxShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
You did a really nice work! I just would do some design changes, but I would need to play around with that in code. Is it ok for you? |
100% OK with me, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, deferring approval considering Bruno is making changes.
| {showPaywall ? ( | ||
| <Paywall | ||
| message="Provisioners" | ||
| description="Provisioners run your Terraform to create templates and workspaces. You need a Premium license to use this feature for multiple organizations." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not just multi-org right? Keys themselves require license too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a copy-paste of the existing paywall:https://github.com/coder/coder/blob/main/site/src/pages/OrganizationSettingsPage/OrganizationProvisionersPage/OrganizationProvisionersPageView.tsx#L100-L102
@johnstcn after my design changes: Screen.Recording.2025-05-19.at.11.57.31.mov
|
ac7961a intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#17698
Demo:
Screen.Recording.2025-05-19.at.11.57.31.mov