- Notifications
You must be signed in to change notification settings - Fork906
feat(agent): addParentId to agent manifest#17888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ParentId to agent manifestParentId to agent manifestParentId to agent manifestParentId to agent manifestThis change introduces a new `ParentId` field to the agent's manifest.This will allow an agent to know if it is a child or not, as well asknowing who the owner is.
0547e45 tofdf5651CompareUh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we also assert that parent is nil if not specified in the manifest? (Essentially the inverse of the test you added)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've updated the original test to have theParentId: null explicit in theexpected struct 👍
agent/proto/agent.proto Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
agent/proto/version.go defines its version as the same version astailnet/proto so I think we need to add a comment intailnet/proto/version.go and bump the minor version.
| @@ -45,9 +45,13 @@ import ( | |||
| // PushResourcesMonitoringUsage RPCs on the Agent API. | |||
| // - Added support for reporting connection events for auditing via the | |||
| // ReportConnection RPC on the Agent API. | |||
| // | |||
| // API v2.5: | |||
| // - Shipped in Coder v2.xx.x // TODO(DanielleMaywood): Update version | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think we can make an educated guess at 2.23 :) but this is fine for now.
61f22a5 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Closescoder/internal#648
This change introduces a new
ParentIdfield to the agent's manifest. This will allow an agent to know if it is a child or not, as well as knowing who the owner is.This is part of the Dev Container Agents RFC work