- Notifications
You must be signed in to change notification settings - Fork907
fix: avoid pulling containers when it is not enabled#17855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -10,6 +10,7 @@ import type { | ||
WorkspaceAgent, | ||
WorkspaceAgentMetadata, | ||
} from "api/typesGenerated"; | ||
import { isAxiosError } from "axios"; | ||
import { DropdownArrow } from "components/DropdownArrow/DropdownArrow"; | ||
import type { Line } from "components/Logs/LogLine"; | ||
import { Stack } from "components/Stack/Stack"; | ||
@@ -160,7 +161,12 @@ export const AgentRow: FC<AgentRowProps> = ({ | ||
select: (res) => res.containers.filter((c) => c.status === "running"), | ||
// TODO: Implement a websocket connection to get updates on containers | ||
// without having to poll. | ||
refetchInterval: (_, query) => { | ||
const { error } = query.state; | ||
return isAxiosError(error) && error.response?.status === 403 | ||
? false | ||
: 10_000; | ||
}, | ||
Comment on lines +166 to +169 Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. So a non-200 and non-403 response will continue to poll forever? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. It will only stop, return false, on 403. Should we cover any other use-case? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. This is probably fine for now | ||
}); | ||
return ( | ||
Uh oh!
There was an error while loading.Please reload this page.