- Notifications
You must be signed in to change notification settings - Fork1k
chore: retry failed race tests in CI#17846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM but deferring approval to someone higher up since this is a pretty big change to how we've tested quality at coder and could open a can of worms
Thanks@deansheather. For reference, this PR is a follow-up to#17681. I couldn't retry race tests back then because it'd mask any detected race conditions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In that case I guess Jon pretty much already approved this then!
6e1ba75 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This PR enables retrying failed tests in the race suites unless a data race was detected. The goal is to reduce how often flakes disrupt developers' workflows.
I bumped gotestsum to a revision from the
mainbranch because it includes the--rerun-fails-abort-on-data-raceflag whichI recently contributed.Incidentally, you can see itin action in a CI job on this very PR.