Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(agent): send devcontainer CLI logs during recreate#17845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 6 commits intomainfrommafredri/feat-agent-devcontainercli-logs
May 15, 2025

Conversation

mafredri
Copy link
Member

We need a way to surface what's happening to the user, since autostart
logs here, it's natural we do so during re-create as well.

Updates#16424

We need a way to surface what's happening to the user, since autostartlogs here, it's natural we do so during re-create as well.Updates#16424
@mafredrimafredriforce-pushed themafredri/feat-agent-devcontainercli-logs branch frome8e84e7 tof144a03CompareMay 15, 2025 08:32
mafredri added a commit that referenced this pull requestMay 15, 2025
…tart scriptThis fixes startup issues when the user shell is set to Fish.Refs:#17845
Comment on lines +108 to +113
for _, script := range scripts {
// The devcontainer scripts match the devcontainer ID for
// identification.
if script.ID == devcontainer.ID {
api.devcontainerLogSourceIDs[devcontainer.WorkspaceFolder] = script.LogSourceID
break
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we warn if there are scripts that do not match up with any devcontainer?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suppose it would be an error rather than warn, this is an expectation coming from the provisioner currently.

Added.

mafredri added a commit that referenced this pull requestMay 15, 2025
…tart (#17847)This fixes startup issues when the user shell is set to Fish.Refs:#17845
@mafredrimafredriforce-pushed themafredri/feat-agent-devcontainercli-logs branch from08509b4 tod9cd988CompareMay 15, 2025 11:54
@mafredrimafredri changed the titlefeat(agent): send devcontainer CLI logs to coderd during recreatefeat(agent): send devcontainer CLI logs during recreateMay 15, 2025
@mafredrimafredri merged commit3de0003 intomainMay 15, 2025
36 checks passed
@mafredrimafredri deleted the mafredri/feat-agent-devcontainercli-logs branchMay 15, 2025 13:06
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@DanielleMaywoodDanielleMaywoodDanielleMaywood left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@mafredri@johnstcn@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp