Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: exclude deleted templates from metrics collection#17839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 10 commits intomainfromyevhenii/metrics-fix
May 15, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina commentedMay 14, 2025•
edited by dannykopping
Loading

Also add some clarification about the lack of database constraints for soft template deletion.

deleted templates cannot have associated workspaces, so it is logically invalid to include themSigned-off-by: Danny Kopping <dannykopping@gmail.com>
@evgeniy-scherbinaevgeniy-scherbina changed the titletest: added duplicate-template-names testtest: add duplicate-template-names testMay 14, 2025
@evgeniy-scherbinaevgeniy-scherbina marked this pull request as ready for reviewMay 14, 2025 23:56
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykopping changed the titletest: add duplicate-template-names testfix: deleted templates should be excluded from metrics collectionMay 15, 2025
@dannykoppingdannykopping changed the titlefix: deleted templates should be excluded from metrics collectionfix: exclude deleted templates from metrics collectionMay 15, 2025
@dannykoppingdannykopping merged commit2aa8cbe intomainMay 15, 2025
61 of 72 checks passed
@dannykoppingdannykopping deleted the yevhenii/metrics-fix branchMay 15, 2025 11:34
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping left review comments

@SasSwartSasSwartSasSwart approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@evgeniy-scherbina@dannykopping@SasSwart
[8]ページ先頭
©2009-2025 Movatter.jp