Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: use static params when dynamic param metadata is missing#17836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 25 commits intomainfromstevenmasley/use_static_as_dynamic
May 16, 2025
Merged
Changes from1 commit
Commits
Show all changes
25 commits
Select commitHold shift + click to select a range
34de4f0
chore: static params as dynmaic
EmyrkMay 14, 2025
005a084
chore: refactor preview code to be swappable
EmyrkMay 14, 2025
55d2af4
Merge remote-tracking branch 'origin/main' into stevenmasley/use_stat…
EmyrkMay 14, 2025
2f5f251
wip
EmyrkMay 14, 2025
d9c5ce5
Working prototype
EmyrkMay 14, 2025
6299f43
work on unit testing
EmyrkMay 15, 2025
f80d838
chore: add unit test for static values
EmyrkMay 15, 2025
a5ee374
revert changes to cache
EmyrkMay 15, 2025
3cb39ea
test: add unit test for closing files
EmyrkMay 15, 2025
d5a68dd
linting
EmyrkMay 15, 2025
bbd0803
chore: move group test to enterprise
EmyrkMay 15, 2025
f5fe4b7
linting
EmyrkMay 15, 2025
dfd0e24
linting
EmyrkMay 15, 2025
1375619
revert deleted coderd/parameters_internal_test.go
EmyrkMay 15, 2025
4dd4149
chore: refactor websocket code into own function
EmyrkMay 15, 2025
f3cff03
fixup
EmyrkMay 15, 2025
13215d6
fix leaked files
EmyrkMay 15, 2025
72f2234
fix up the error message for static params for now
EmyrkMay 15, 2025
4ea0165
linting
EmyrkMay 15, 2025
ef15df1
move release to only if err == nil
EmyrkMay 15, 2025
df65b92
use options pattern for provisioner version override
EmyrkMay 15, 2025
2bb3749
Merge remote-tracking branch 'origin/main' into stevenmasley/use_stat…
EmyrkMay 16, 2025
5957960
fixup error message assert
EmyrkMay 16, 2025
62db9dd
1.5 -> 1.6
EmyrkMay 16, 2025
5a9b4ac
Merge remote-tracking branch 'origin/main' into stevenmasley/use_stat…
EmyrkMay 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
linting
  • Loading branch information
@Emyrk
Emyrk committedMay 15, 2025
commit4ea01657690a2a7987172b308b0c43f06f7794c6
2 changes: 1 addition & 1 deletioncoderd/parameters.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -241,7 +241,7 @@ func (api *API) handleStaticParameters(rw http.ResponseWriter, r *http.Request,
params = append(params, param)
}

api.handleParameterWebsocket(rw, r, func(ctx context.Context, values map[string]string) (*preview.Output, hcl.Diagnostics) {
api.handleParameterWebsocket(rw, r, func(_ context.Context, values map[string]string) (*preview.Output, hcl.Diagnostics) {
for i := range params {
param := &params[i]
paramValue, ok := values[param.Name]
Expand Down
Loading

[8]ページ先頭

©2009-2026 Movatter.jp