Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(coderd/agentapi): implement sub agent api#17823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DanielleMaywood merged 34 commits intomainfromdm-devcontainer-agents-coderd
May 29, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
Show all changes
34 commits
Select commitHold shift + click to select a range
dea341d
chore: begin impl of dev container agent's `/coderd/agenetapi`
DanielleMaywoodMay 13, 2025
5c6d5fe
chore: add WorkspaceAgent rbac policy
DanielleMaywoodMay 14, 2025
62ebd44
chore: add Architecture and OperatingSystem to agent.proto
DanielleMaywoodMay 14, 2025
0857054
chore: remove todo
DanielleMaywoodMay 14, 2025
993b671
chore: appease linter
DanielleMaywoodMay 14, 2025
5895d55
chore: add system context for test
DanielleMaywoodMay 14, 2025
c4af28b
chore: remove outdated code
DanielleMaywoodMay 21, 2025
c2deb25
chore: replace google.protobuf.Empty with DeleteDevContainerAgentResp…
DanielleMaywoodMay 21, 2025
1fe6fe3
chore: make test larger
DanielleMaywoodMay 21, 2025
7fd59db
refactor: tests
DanielleMaywoodMay 21, 2025
b1f8e42
chore: appease linter
DanielleMaywoodMay 21, 2025
eb881ea
chore: begin validating agent name
DanielleMaywoodMay 21, 2025
924699c
chore: listen to feedback
DanielleMaywoodMay 21, 2025
b60d42d
chore: rename GetWorkspaceAgentsWithParentID
DanielleMaywoodMay 22, 2025
505c0cc
chore: ensure createdAt and updatedAt match
DanielleMaywoodMay 22, 2025
1af33bc
chore: rbac
DanielleMaywoodMay 22, 2025
1731e5f
chore: appease formatter
DanielleMaywoodMay 22, 2025
7b06e6f
tests: refactor and add some adversarial tests
DanielleMaywoodMay 22, 2025
0c37a92
test: behavior is correct with no child agents
DanielleMaywoodMay 22, 2025
ef5772d
chore: appease linter
DanielleMaywoodMay 22, 2025
cb89e03
Merge branch 'main' into dm-devcontainer-agents-coderd
DanielleMaywoodMay 22, 2025
94a2d59
chore: update DRPCAgentClient25 interface
DanielleMaywoodMay 22, 2025
ec4dda9
chore: rename sql parameter
DanielleMaywoodMay 22, 2025
0c8be91
Merge branch 'main' into dm-devcontainer-agents-coderd
DanielleMaywoodMay 27, 2025
34d870a
Merge branch 'main' into dm-devcontainer-agents-coderd
DanielleMaywoodMay 28, 2025
cb965ea
chore: remove comment as recent PR resolves issue
DanielleMaywoodMay 28, 2025
979f4ef
refactor: devcontainer agent -> subagent
DanielleMaywoodMay 28, 2025
2ffc0e3
refactor: deleteworkspaceagent to deleteworkspacesubagent
DanielleMaywoodMay 28, 2025
f1a4da3
fix: appease linter
DanielleMaywoodMay 29, 2025
036436b
test: paranoia
DanielleMaywoodMay 29, 2025
c6ded1f
Merge branch 'main' into dm-devcontainer-agents-coderd
DanielleMaywoodMay 29, 2025
0871c82
chore: apply feedback from spike
DanielleMaywoodMay 29, 2025
b7e64ef
test: check err is a not authorized error
DanielleMaywoodMay 29, 2025
1c28667
fix: remove unused code
DanielleMaywoodMay 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletionsagent/agent.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -95,8 +95,8 @@ type Options struct {
}

type Client interface {
ConnectRPC25(ctx context.Context) (
proto.DRPCAgentClient25, tailnetproto.DRPCTailnetClient25, error,
ConnectRPC26(ctx context.Context) (
proto.DRPCAgentClient26, tailnetproto.DRPCTailnetClient26, error,
)
RewriteDERPMap(derpMap *tailcfg.DERPMap)
}
Expand DownExpand Up@@ -908,7 +908,7 @@ func (a *agent) run() (retErr error) {
a.sessionToken.Store(&sessionToken)

// ConnectRPC returns the dRPC connection we use for the Agent and Tailnet v2+ APIs
aAPI, tAPI, err := a.client.ConnectRPC25(a.hardCtx)
aAPI, tAPI, err := a.client.ConnectRPC26(a.hardCtx)
if err != nil {
return err
}
Expand Down
16 changes: 14 additions & 2 deletionsagent/agenttest/client.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -98,8 +98,8 @@ func (c *Client) Close() {
c.derpMapOnce.Do(func() { close(c.derpMapUpdates) })
}

func (c *Client)ConnectRPC25(ctx context.Context) (
agentproto.DRPCAgentClient25, proto.DRPCTailnetClient25, error,
func (c *Client)ConnectRPC26(ctx context.Context) (
agentproto.DRPCAgentClient26, proto.DRPCTailnetClient26, error,
) {
conn, lis := drpcsdk.MemTransportPipe()
c.LastWorkspaceAgent = func() {
Expand DownExpand Up@@ -365,6 +365,18 @@ func (f *FakeAgentAPI) GetConnectionReports() []*agentproto.ReportConnectionRequ
return slices.Clone(f.connectionReports)
}

func (*FakeAgentAPI) CreateSubAgent(_ context.Context, _ *agentproto.CreateSubAgentRequest) (*agentproto.CreateSubAgentResponse, error) {
panic("unimplemented")
}

func (*FakeAgentAPI) DeleteSubAgent(_ context.Context, _ *agentproto.DeleteSubAgentRequest) (*agentproto.DeleteSubAgentResponse, error) {
panic("unimplemented")
}

func (*FakeAgentAPI) ListSubAgents(_ context.Context, _ *agentproto.ListSubAgentsRequest) (*agentproto.ListSubAgentsResponse, error) {
panic("unimplemented")
}

func NewFakeAgentAPI(t testing.TB, logger slog.Logger, manifest *agentproto.Manifest, statsCh chan *agentproto.Stats) *FakeAgentAPI {
return &FakeAgentAPI{
t: t,
Expand Down
Loading
Loading

[8]ページ先頭

©2009-2025 Movatter.jp