Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add copy button for workspace name in breadcrumb#17822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
matifali merged 3 commits intomainfromatif/issue-17829
May 15, 2025

Conversation

matifali
Copy link
Member

@matifalimatifali commentedMay 14, 2025•
edited by BrunoQuaresma
Loading

Closes#17820

Demo

Screen.Recording.2025-05-14.at.08.37.42.mov

@matifalimatifali self-assigned thisMay 14, 2025
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 14, 2025
@BrunoQuaresmaBrunoQuaresma requested review froma team,BrunoQuaresma andjaaydenh and removed request forBrunoQuaresma anda teamMay 14, 2025 12:04
@Emyrk
Copy link
Member

Emyrk commentedMay 15, 2025•
edited
Loading

Is this a storybook thing, or has the spacing really changed on the nav bar here?
The new code looks to have a bit more spacing.

Screenshot From 2025-05-15 11-53-31

https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=68248278c9d187b52c4ff47f

@BrunoQuaresma
Copy link
Collaborator

@Emyrk it changed, but it still looking good 👍

Emyrk reacted with thumbs up emoji

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I mostly reviewed via chromatic storybook changes 😄

@matifalimatifali merged commit2c49fd9 intomainMay 15, 2025
34 checks passed
@matifalimatifali deleted the atif/issue-17829 branchMay 15, 2025 17:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@jatcod3rjatcod3rAwaiting requested review from jatcod3r

@jaaydenhjaaydenhAwaiting requested review from jaaydenhjaaydenh was automatically assigned from coder/ts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Copy Button to the Workspace Name
3 participants
@matifali@Emyrk@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp