Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: replace MUI LoadingButton with Button + Spinner - 1#17816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/replace-loading-buttons
May 14, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresmaBrunoQuaresma requested a review froma teamMay 14, 2025 00:01
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 14, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromParkreiner and removed request fora teamMay 14, 2025 00:01
@BrunoQuaresmaBrunoQuaresma changed the titlechore: replace MUI LoadingButton - 1chore: replace MUI LoadingButton with Button + Spinner - 1May 14, 2025
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Chromatic reviewed

css={{ minWidth: "auto", aspectRatio: "1" }}
<Button
variant="outline"
size="sm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: button font is smaller according to Chromatic, is it expected?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let me check 👀

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, it is!

@BrunoQuaresmaBrunoQuaresma merged commitc7bc404 intomainMay 14, 2025
38 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/replace-loading-buttons branchMay 14, 2025 12:35
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@mtojekmtojekmtojek approved these changes

@ParkreinerParkreinerAwaiting requested review from ParkreinerParkreiner was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@BrunoQuaresma@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp