- Notifications
You must be signed in to change notification settings - Fork913
chore: replace MUI icons with Lucide icons - 11#17814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,13 +1,12 @@ | ||||||
import { type Interpolation, type Theme, useTheme } from "@emotion/react"; | ||||||
import { visuallyHidden } from "@mui/utils"; | ||||||
import type { Workspace } from "api/typesGenerated"; | ||||||
import { ConfirmDialog } from "components/Dialogs/ConfirmDialog/ConfirmDialog"; | ||||||
import { ExternalImage } from "components/ExternalImage/ExternalImage"; | ||||||
import { Stack } from "components/Stack/Stack"; | ||||||
import dayjs from "dayjs"; | ||||||
import relativeTime from "dayjs/plugin/relativeTime"; | ||||||
import { ClockIcon, UserIcon } from "lucide-react"; | ||||||
import { type FC, type ReactNode, useState } from "react"; | ||||||
import { getResourceIconPath } from "utils/workspace"; | ||||||
@@ -190,7 +189,7 @@ const Workspaces: FC<StageProps> = ({ workspaces }) => { | ||||||
> | ||||||
{dayjs(workspace.last_used_at).fromNow()} | ||||||
</span> | ||||||
<ClockIcon className="size-icon-xs" /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I do agree with you, but since it is not in the scope of this PR, I will leave as it is ok? | ||||||
</Stack> | ||||||
</Stack> | ||||||
</Stack> | ||||||
@@ -209,7 +208,7 @@ const Workspaces: FC<StageProps> = ({ workspaces }) => { | ||||||
</Stack> | ||||||
{mostRecent && ( | ||||||
<Stack direction="row" alignItems="center" spacing={1}> | ||||||
<ClockIcon className="size-icon-xs" /> | ||||||
<span>Last used {dayjs(mostRecent.last_used_at).fromNow()}</span> | ||||||
</Stack> | ||||||
)} | ||||||
@@ -264,10 +263,8 @@ const Resources: FC<StageProps> = ({ workspaces }) => { | ||||||
}; | ||||||
const PersonIcon: FC = () => { | ||||||
// Using the Lucide icon with appropriate size class | ||||||
return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
See my other comment in BatchUpdateConfirmation.tsx | ||||||
}; | ||||||
const styles = { | ||||||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,5 @@ | ||
import type { Interpolation, Theme } from "@emotion/react"; | ||
import InstallDesktopIcon from "@mui/icons-material/InstallDesktop"; | ||
import { API } from "api/api"; | ||
import type { TemplateVersion, Workspace } from "api/typesGenerated"; | ||
import { ErrorAlert } from "components/Alert/ErrorAlert"; | ||
@@ -12,6 +9,7 @@ import { MemoizedInlineMarkdown } from "components/Markdown/Markdown"; | ||
import { Stack } from "components/Stack/Stack"; | ||
import dayjs from "dayjs"; | ||
import relativeTime from "dayjs/plugin/relativeTime"; | ||
import { ClockIcon, SettingsIcon, UserIcon } from "lucide-react"; | ||
import { type FC, type ReactNode, useEffect, useMemo, useState } from "react"; | ||
import { useQueries } from "react-query"; | ||
@@ -293,7 +291,7 @@ const DormantWorkspaces: FC<DormantWorkspacesProps> = ({ workspaces }) => { | ||
</span> | ||
</Stack> | ||
<Stack direction="row" alignItems="center" spacing={1}> | ||
<ClockIcon className="size-icon-xs" /> | ||
<span | ||
css={{ whiteSpace: "nowrap", textOverflow: "ellipsis" }} | ||
> | ||
@@ -317,7 +315,7 @@ const DormantWorkspaces: FC<DormantWorkspacesProps> = ({ workspaces }) => { | ||
</Stack> | ||
{mostRecent && ( | ||
<Stack direction="row" alignItems="center" spacing={1}> | ||
<ClockIcon className="size-icon-xs" /> | ||
<span>Last used {lastUsed(mostRecent.last_used_at)}</span> | ||
</Stack> | ||
)} | ||
@@ -358,7 +356,7 @@ const Updates: FC<UpdatesProps> = ({ workspaces, updates, error }) => { | ||
</Stack> | ||
{updateCount && ( | ||
<Stack direction="row" alignItems="center" spacing={1}> | ||
<SettingsIcon className="size-icon-xs" /> | ||
<span>{updateCount}</span> | ||
</Stack> | ||
)} | ||
@@ -433,10 +431,8 @@ const lastUsed = (time: string) => { | ||
}; | ||
const PersonIcon: FC = () => { | ||
// Using the Lucide icon with appropriate size class | ||
return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I think the size-icon-xs looks better. Didn't you? | ||
}; | ||
const styles = { | ||
Uh oh!
There was an error while loading.Please reload this page.