- Notifications
You must be signed in to change notification settings - Fork907
chore: replace MUI icons with Lucide icons - 11#17814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
aqandrew left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I was able to view all of the components in Storybook except the sidebars, but the changes lgtm! Just some minor alignment nits
| // on the sides to compensate. | ||
| return <PersonOutlinedIcon css={{ width: 18, height: 18, margin: -1 }} />; | ||
| // Using the Lucide icon with appropriate size class | ||
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| return<UserIconclassName="size-icon-sm"css={{margin:-1}}/>; | |
| return<UserIconclassName="size-icon-xs"/>; |
What's the reason for usingsize-icon-sm onUserIcon?
This causes the text to be misaligned on the left side:
The text becomes left-aligned withsize-icon-xs:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think the size-icon-xs looks better. Didn't you?
| // on the sides to compensate. | ||
| return <PersonOutlinedIcon css={{ width: 18, height: 18, margin: -1 }} />; | ||
| // Using the Lucide icon with appropriate size class | ||
| return <UserIcon className="size-icon-sm" css={{ margin: -1 }} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| return<UserIconclassName="size-icon-sm"css={{margin:-1}}/>; | |
| return<UserIconclassName="size-icon-xs"/>; |
See my other comment in BatchUpdateConfirmation.tsx
| @@ -190,7 +189,7 @@ const Workspaces: FC<StageProps> = ({ workspaces }) => { | |||
| > | |||
| {dayjs(workspace.last_used_at).fromNow()} | |||
| </span> | |||
| <ScheduleIcon css={styles.summaryIcon} /> | |||
| <ClockIcon className="size-icon-xs" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: Now that I look at both of the dialogs...why does the delete dialog show icons on the right, while the update dialog shows icons on the left? IMO the icons should be on the left in both dialogs, to keep consistency with themostRecent info below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I do agree with you, but since it is not in the scope of this PR, I will leave as it is ok?
f87dbe7 intomainUh oh!
There was an error while loading.Please reload this page.
I did some mess using Graphite, sorry. I will address your comments and ping you. |
PersonOutlined -> UserIcon
Schedule -> ClockIcon
SettingsSuggest -> SettingsIcon
SettingsOutlined -> SettingsIcon
CodeOutlined -> CodeIcon
TimerOutlined -> TimerIcon