May 30, 2025 · May 13, 2025 · May 13, 2025 · May 13, 2025 · May 13, 2025 · May 13, 2025
diff --git a/site/src/contexts/ProxyContext.test.tsx b/site/src/contexts/ProxyContext.test.tsx
 // here and not inside a unit test.
 jest.mock("contexts/useProxyLatency", () => ({
 useProxyLatency: () => {
 return { proxyLatencies: hardCodedLatencies, refetch: jest.fn() };
 return {
 proxyLatencies: hardCodedLatencies,
 refetch: jest.fn(),
 loaded: true,
 };
 },
 }));

 expUserProxyID: MockHealthyWildWorkspaceProxy.id,
 },
 ],
 //Latency behavior is disabled, so theprimary should be selected.
 //First page load defers to theproxy by latency
 [
 "regions_default_low_latency",
 {
 expProxyID:MockPrimaryWorkspaceProxy.id,
 expProxyID:MockHealthyWildWorkspaceProxy.id,
 regions: MockWorkspaceProxies,
 storageProxy: undefined,
 latencies: {
diff --git a/site/src/contexts/ProxyContext.tsx b/site/src/contexts/ProxyContext.tsx

 // Every time we get a new proxiesResponse, update the latency check
 // to each workspace proxy.
 const { proxyLatencies, refetch: refetchProxyLatencies } =
 useProxyLatency(proxiesResp);
 const {
 proxyLatencies,
 refetch: refetchProxyLatencies,
 loaded: latenciesLoaded,
 } = useProxyLatency(proxiesResp);

 // updateProxy is a helper function that when called will
 // update the proxy being used.
 loadUserSelectedProxy(),
 proxyLatencies,
 // Do not auto select based on latencies, as inconsistent latencies can cause this
 // to behave poorly.
 // to change on each call. updateProxy should be stable when selecting a proxy to
 // prevent flickering.
 false,
 ),
 );
 updateProxy();
 }, [proxiesResp, proxyLatencies]);

 // This useEffect will auto select the best proxy if the user has not selected one.
 // It must wait until all latencies are loaded to select based on latency. This does mean
 // the first time a user loads the page, the proxy will "flicker" to the best proxy.
 //
 // Once the page is loaded, or the user selects a proxy, this will not run again.
 // biome-ignore lint/correctness/useExhaustiveDependencies: Only update if the source data changes
 useEffect(() => {
 if (loadUserSelectedProxy() !== undefined) {
 return; // User has selected a proxy, do not auto select.
 }
 if (!latenciesLoaded) {
 // Wait until the latencies are loaded before
 return;
 }

 const best = getPreferredProxy(
 proxiesResp ?? [],
 loadUserSelectedProxy(),
 proxyLatencies,
 true,
 );

 if (best?.proxy) {
 saveUserSelectedProxy(best.proxy);
 updateProxy();
 }
 }, [latenciesLoaded, proxiesResp, proxyLatencies]);

 return (
 <ProxyContext.Provider
 value={{

 // If no proxy is selected, or the selected proxy is unhealthy default to the primary proxy.
 if (!selectedProxy || !selectedProxy.healthy) {
 // By default, use the primary proxy.
 selectedProxy = proxies.find((proxy) => proxy.name === "primary");

 // If we have latencies, then attempt to use the best proxy by latency instead.
 const best = selectByLatency(proxies, latencies);
 if (autoSelectBasedOnLatency && best) {
 selectedProxy = best;
 }

 // Use the primary proxy if we don't have  any other options.
 if (!selectedProxy) {
 selectedProxy = proxies.find((proxy) => proxy.name === "primary");
 }
 }

 return computeUsableURLS(selectedProxy);
diff --git a/site/src/contexts/useProxyLatency.ts b/site/src/contexts/useProxyLatency.ts
 // Until the new values are loaded, the old values will still be used.
 refetch: () => Date;
 proxyLatencies: Record<string, ProxyLatencyReport>;
 loaded: boolean;
 } => {
 // maxStoredLatencies is the maximum number of latencies to store per proxy in local storage.
 let maxStoredLatencies = 1;
 new Date(new Date().getTime() - proxyIntervalSeconds * 1000).toISOString(),
 );

 const [loaded, setLoaded] = useState(false);

 // Refetch will always set the latestFetchRequest to the current time, making all the cached latencies
 // stale and triggering a refetch of all proxies in the list.
 const refetch = () => {

 // Local storage cleanup
 garbageCollectStoredLatencies(proxies, maxStoredLatencies);
 setLoaded(true);
 });

 return () => {
 return {
 proxyLatencies,
 refetch,
 loaded,
 };
 };
Original file line number	Diff line number	Diff line change
Expand Up		@@ -26,7 +26,11 @@ import type * as ProxyLatency from "./useProxyLatency";
		// here and not inside a unit test.
		jest.mock("contexts/useProxyLatency", () => ({
		useProxyLatency: () => {
		return { proxyLatencies: hardCodedLatencies, refetch: jest.fn() };
		return {
		proxyLatencies: hardCodedLatencies,
		refetch: jest.fn(),
		loaded: true,
		};
		},
		}));

Expand DownExpand Up		@@ -261,11 +265,11 @@ describe("ProxyContextSelection", () => {
		expUserProxyID: MockHealthyWildWorkspaceProxy.id,
		},
		],
		//Latency behavior is disabled, so theprimary should be selected.
		//First page load defers to theproxy by latency
		[
		"regions_default_low_latency",
		{
		expProxyID:MockPrimaryWorkspaceProxy.id,
		expProxyID:MockHealthyWildWorkspaceProxy.id,
		regions: MockWorkspaceProxies,
		storageProxy: undefined,
		latencies: {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -122,8 +122,11 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {

		// Every time we get a new proxiesResponse, update the latency check
		// to each workspace proxy.
		const { proxyLatencies, refetch: refetchProxyLatencies } =
		useProxyLatency(proxiesResp);
		const {
		proxyLatencies,
		refetch: refetchProxyLatencies,
		loaded: latenciesLoaded,
		} = useProxyLatency(proxiesResp);

		// updateProxy is a helper function that when called will
		// update the proxy being used.
Expand All		@@ -136,7 +139,8 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
		loadUserSelectedProxy(),
		proxyLatencies,
		// Do not auto select based on latencies, as inconsistent latencies can cause this
		// to behave poorly.
		// to change on each call. updateProxy should be stable when selecting a proxy to
		// prevent flickering.
		false,
		),
		);
Expand All		@@ -149,6 +153,34 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
		updateProxy();
		}, [proxiesResp, proxyLatencies]);

		// This useEffect will auto select the best proxy if the user has not selected one.
		// It must wait until all latencies are loaded to select based on latency. This does mean
		// the first time a user loads the page, the proxy will "flicker" to the best proxy.
		//
		// Once the page is loaded, or the user selects a proxy, this will not run again.
		// biome-ignore lint/correctness/useExhaustiveDependencies: Only update if the source data changes
		useEffect(() => {
		if (loadUserSelectedProxy() !== undefined) {
		return; // User has selected a proxy, do not auto select.
		}
		if (!latenciesLoaded) {
		// Wait until the latencies are loaded before
		return;
		}

		const best = getPreferredProxy(
		proxiesResp ?? [],
		loadUserSelectedProxy(),
		proxyLatencies,
		true,
		);

		if (best?.proxy) {
		saveUserSelectedProxy(best.proxy);
		updateProxy();
		}
		}, [latenciesLoaded, proxiesResp, proxyLatencies]);

		return (
		<ProxyContext.Provider
		value={{
Expand DownExpand Up		@@ -214,14 +246,16 @@ export const getPreferredProxy = (

		// If no proxy is selected, or the selected proxy is unhealthy default to the primary proxy.
		if (!selectedProxy \|\| !selectedProxy.healthy) {
		// By default, use the primary proxy.
		selectedProxy = proxies.find((proxy) => proxy.name === "primary");

		// If we have latencies, then attempt to use the best proxy by latency instead.
		const best = selectByLatency(proxies, latencies);
		if (autoSelectBasedOnLatency && best) {
		selectedProxy = best;
		}

		// Use the primary proxy if we don't have any other options.
		if (!selectedProxy) {
		selectedProxy = proxies.find((proxy) => proxy.name === "primary");
		}
		}

		return computeUsableURLS(selectedProxy);
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -48,6 +48,7 @@ export const useProxyLatency = (
		// Until the new values are loaded, the old values will still be used.
		refetch: () => Date;
		proxyLatencies: Record<string, ProxyLatencyReport>;
		loaded: boolean;
		} => {
		// maxStoredLatencies is the maximum number of latencies to store per proxy in local storage.
		let maxStoredLatencies = 1;
Expand All		@@ -73,6 +74,8 @@ export const useProxyLatency = (
		new Date(new Date().getTime() - proxyIntervalSeconds * 1000).toISOString(),
		);

		const [loaded, setLoaded] = useState(false);
Copy link MemberAuthor EmyrkMay 13, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This is how I track when the latencies are done loading, since they all come back async

		// Refetch will always set the latestFetchRequest to the current time, making all the cached latencies
		// stale and triggering a refetch of all proxies in the list.
		const refetch = () => {
Expand DownExpand Up		@@ -231,6 +234,7 @@ export const useProxyLatency = (

		// Local storage cleanup
		garbageCollectStoredLatencies(proxies, maxStoredLatencies);
		setLoaded(true);
		});

		return () => {
Expand All		@@ -241,6 +245,7 @@ export const useProxyLatency = (
		return {
		proxyLatencies,
		refetch,
		loaded,
		};
		};

Expand Down