Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: set default workspace proxy based on latency#17812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 21 commits intomainfromstevenmasley/auto_select_first
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
21 commits
Select commitHold shift + click to select a range
ab3f897
feat: default workspace proxy based on latency
EmyrkMay 13, 2025
fd172b7
always save the proxy
EmyrkMay 13, 2025
5de9d61
save the first latency report back
EmyrkMay 13, 2025
e0b9eb3
add comments
EmyrkMay 13, 2025
5427b61
unit test
EmyrkMay 13, 2025
dcf98d7
comment
EmyrkMay 13, 2025
93bc6b3
fmt
EmyrkMay 13, 2025
f5c0719
add latenciesLoaded to unit tests
EmyrkMay 14, 2025
f2b5d9c
fixup tests
EmyrkMay 14, 2025
b3102b7
fixup test fixtures
EmyrkMay 14, 2025
d07e472
fmt
EmyrkMay 14, 2025
abf49ae
remove console log, whoops
EmyrkMay 14, 2025
6755899
add comments
EmyrkMay 14, 2025
3383a80
Merge branch 'main' into stevenmasley/auto_select_first
EmyrkMay 14, 2025
fdb545c
Merge remote-tracking branch 'origin/main' into stevenmasley/auto_sel…
EmyrkMay 15, 2025
f5b76e4
Merge branch 'main' into stevenmasley/auto_select_first
EmyrkMay 19, 2025
a528411
Merge branch 'main' into stevenmasley/auto_select_first
EmyrkMay 23, 2025
8cc71ea
Merge remote-tracking branch 'origin/main' into stevenmasley/auto_sel…
EmyrkMay 27, 2025
9d9e7f3
revert to main
EmyrkMay 27, 2025
6036996
fix js test
EmyrkMay 27, 2025
01aebed
fix js test
EmyrkMay 27, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
fmt
  • Loading branch information
@Emyrk
Emyrk committedMay 13, 2025
commit93bc6b372c107edcb4424ea1fb9df51a53888124
6 changes: 5 additions & 1 deletionsite/src/contexts/ProxyContext.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,11 @@ import type * as ProxyLatency from "./useProxyLatency";
// here and not inside a unit test.
jest.mock("contexts/useProxyLatency", () => ({
useProxyLatency: () => {
return { proxyLatencies: hardCodedLatencies, refetch: jest.fn(), loaded: true };
return {
proxyLatencies: hardCodedLatencies,
refetch: jest.fn(),
loaded: true,
};
},
}));

Expand Down
21 changes: 12 additions & 9 deletionssite/src/contexts/ProxyContext.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -122,8 +122,11 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {

// Every time we get a new proxiesResponse, update the latency check
// to each workspace proxy.
const { proxyLatencies, refetch: refetchProxyLatencies, loaded: latenciesLoaded } =
useProxyLatency(proxiesResp);
const {
proxyLatencies,
refetch: refetchProxyLatencies,
loaded: latenciesLoaded,
} = useProxyLatency(proxiesResp);

// updateProxy is a helper function that when called will
// update the proxy being used.
Expand DownExpand Up@@ -153,13 +156,14 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
// This useEffect will auto select the best proxy if the user has not selected one.
// It must wait until all latencies are loaded to select based on latency. This does mean
// the first time a user loads the page, the proxy will "flicker" to the best proxy.
//
//
// Once the page is loaded, or the user selects a proxy, this will not run again.
// biome-ignore lint/correctness/useExhaustiveDependencies: Only update if the source data changes
useEffect(() => {
if(loadUserSelectedProxy() !== undefined) {
if(loadUserSelectedProxy() !== undefined) {
return; // User has selected a proxy, do not auto select.
}
if(!latenciesLoaded) {
if(!latenciesLoaded) {
// Wait until the latencies are loaded before
return;
}
Expand All@@ -171,12 +175,11 @@ export const ProxyProvider: FC<PropsWithChildren> = ({ children }) => {
true,
);

if(best?.proxy) {
if(best?.proxy) {
saveUserSelectedProxy(best.proxy);
updateProxy();
}

}, [latenciesLoaded])
}, [latenciesLoaded, proxiesResp, proxyLatencies]);

return (
<ProxyContext.Provider
Expand DownExpand Up@@ -250,7 +253,7 @@ export const getPreferredProxy = (
}

// Use the primary proxy if we don't have any other options.
if(!selectedProxy) {
if(!selectedProxy) {
selectedProxy = proxies.find((proxy) => proxy.name === "primary");
}
}
Expand Down
2 changes: 1 addition & 1 deletionsite/src/contexts/useProxyLatency.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -245,7 +245,7 @@ export const useProxyLatency = (
return {
proxyLatencies,
refetch,
loaded
loaded,
};
};

Expand Down
Loading

[8]ページ先頭

©2009-2026 Movatter.jp