Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: replace badge by status indicator#17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 2 commits intomainfrombq/replace-badge-by-indicator
May 14, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedMay 13, 2025
edited
Loading

Why?
In the workspaces page, it is using the status indicator, and not the badge anymore, so to keep the UI consistent, I'm replacing the badge by the indicator in the workspace page too.

Before:
Screenshot 2025-05-13 at 19 14 17

After:
Screenshot 2025-05-13 at 19 14 21

@BrunoQuaresmaBrunoQuaresma requested review froma team,Kira-Pilot andaslilac and removed request fora team andKira-PilotMay 13, 2025 22:26
gap:8,
}}
>
<divclassName="flex items-center gap-4">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

curious: why is it better thancss property?

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Because we are moving away from MUI and emotion to use shadcn and TailwindCSS. So we want to be consistent and only use the new stack.

mtojek reacted with hooray emoji
Copy link
Member

@mtojekmtojekMay 14, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the explanation, TIL!

BrunoQuaresma reacted with heart emoji
@BrunoQuaresmaBrunoQuaresma merged commitfcbdd1a intomainMay 14, 2025
29 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/replace-badge-by-indicator branchMay 14, 2025 12:11
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mtojekmtojekmtojek approved these changes

@aslilacaslilacAwaiting requested review from aslilacaslilac was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrunoQuaresma@mtojek

[8]ページ先頭

©2009-2025 Movatter.jp