- Notifications
You must be signed in to change notification settings - Fork907
feat: add ConvertUserLoginType func to codersdk#17784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Emyrk merged 1 commit intocoder:mainfrombetterlmy:feature/add-ConvertUserLoginType-functionMay 27, 2025
Merged
feat: add ConvertUserLoginType func to codersdk#17784
Emyrk merged 1 commit intocoder:mainfrombetterlmy:feature/add-ConvertUserLoginType-functionMay 27, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedMay 13, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
2f29b2d to955b588CompareI have read the CLA Document and I hereby sign the CLA |
cdrci2 added a commit to coder/cla that referenced this pull requestMay 13, 2025
recheck |
Uh oh!
There was an error while loading.Please reload this page.
955b588 tofb695d6CompareEmyrk approved these changesMay 27, 2025
71a647b intocoder:main 29 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 New Feature
Added
ConvertUserLoginType(ctx, user, req)method to support converting the login type for a specified user.📌 Background
The existing
ConvertLoginTypemethod only supports converting the current user's login type (via the /api/v2/users/me/convert-login endpoint).In our use case, we needed to convert the login type for other users programmatically, which the SDK did not support.
This new method constructs the endpoint dynamically using the provided username, enabling conversion for any user.
✅ Compatibility
This is an additive change and does not modify any existing functionality.
The original ConvertLoginType remains unchanged.