Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add API/SDK support for autostop extension#1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 11 commits intomainfromcj/autostop-extend-api
May 26, 2022

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMay 26, 2022•
edited
Loading

  • Addsdeadline column toworkspace_builds, associated DB/API plumbing
  • database: Upon inserting a row intoworkspace_builds, deadline will be initially be zero.
  • autobuild:Executor will now check theDeadline field of the workspace_build for the purpose of autostop logic.
  • coderd: Adds a new route/api/v2/workspaces/:workspace/extend which will allow updating the deadline of the currently active workspace build. The new deadline must be after the existing deadline, and not the zero time.
  • provisionerd: update workspace_build.deadline upon successful workspace build completion (equal to now plus workspace TTL, if it exists)

Closes#1462

@johnstcnjohnstcn requested a review froma teamMay 26, 2022 12:55
@johnstcnjohnstcn requested a review froma team as acode ownerMay 26, 2022 12:55
@johnstcnjohnstcn self-assigned thisMay 26, 2022
@johnstcnjohnstcn requested a review fromgreyscaledMay 26, 2022 12:55
Copy link
Member

@deansheatherdeansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

So what will be the behavior when the user changes the TTL on a running workspace? Will you add functionality to the CLI so we also update the TTL to be closer to the new TTL?

@johnstcn
Copy link
MemberAuthor

johnstcn commentedMay 26, 2022•
edited
Loading

So what will be the behavior when the user changes the TTL on a running workspace? Will you add functionality to the CLI so we also update the TTL to be closer to the new TTL?

Good idea!

EDIT: Opened separate issue as this has a lot of if's and but's#1783

Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor comments

@johnstcnjohnstcnforce-pushed thecj/autostop-extend-api branch fromded669b to03ec987CompareMay 26, 2022 16:48
@johnstcnjohnstcn merged commit8f0a5a8 intomainMay 26, 2022
@johnstcnjohnstcn deleted the cj/autostop-extend-api branchMay 26, 2022 17:08
kylecarbs pushed a commit that referenced this pull requestJun 10, 2022
* Adds deadline column to workspace_builds, associated DB/API plumbing* database: Upon inserting a row into workspace_builds, deadline will   initially be zero.* autobuild: Executor now checks the Deadline field of the workspace_build  for the purpose of autostop logic.* coderd: Adds a new route /api/v2/workspaces/:workspace/extend which allows  updating the deadline of the currently active workspace build. The new  deadline must be after the existing deadline, and not the zero time.* provisionerd: updates workspace_build.deadline upon successful workspace   build completion (equal to now plus workspace TTL, if it exists).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@EmyrkEmyrkEmyrk left review comments

@greyscaledgreyscaledgreyscaled approved these changes

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API/SDK auto-stop extension
4 participants
@johnstcn@Emyrk@greyscaled@deansheather
[8]ページ先頭
©2009-2025 Movatter.jp