- Notifications
You must be signed in to change notification settings - Fork907
feat: addis_prebuild_claim to distinguish post-claim provisioning#17757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've suggested a different name for the field, but I don't need to review again.
| string running_workspace_agent_token = 21; | ||
| bool is_prebuild = 20; // Indicates that a prebuilt workspace is being built. | ||
| string running_workspace_agent_token = 21; // Preserves the running agent token of a prebuilt workspace so it can reinitialize. | ||
| bool is_prebuild_claim = 22; // Indicates that a prebuilt workspace is being claimed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| boolis_prebuild_claim = 22;// Indicates that a prebuilt workspace is being claimed. | |
| boolclaims_prebuilt_workspace = 22;// Indicates that a prebuilt workspace is being claimed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You're right; I probably shouldn't refer to "prebuild" here.
I'll make itis_prebuilt_workspace_claim to be similar in form tois_prebuild, since they're related fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You could make them a single enum...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could work, lemme try it and see how it feels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@spikecurtis great suggestion, this is more in line with how we do other things like workspace transitions; should've done this from the beginning.
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
af2941b intomainUh oh!
There was an error while loading.Please reload this page.
Used in combination withcoder/terraform-provider-coder#396
This is required by both#17475 and#17571
Operators may need to conditionalize their templates to perform certain operations once a prebuilt workspace has been claimed. This value willonly be set once a claim takes place and a subsequent
terraform applyoccurs. Anyterraform applyruns thereafter will be indistinguishable from a normal run on a workspace.