Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: tune postgres CI tests#17756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugodutka merged 1 commit intomainfromhugodutka/ci-windows-macos-tuning
May 12, 2025

Conversation

hugodutka
Copy link
Contributor

@hugodutkahugodutka commentedMay 11, 2025
edited
Loading

Changes:

  • use a bigger runner for test-go-pg on Linux
  • use a depot runner to run postgres tests on Windows
  • use the same Windows ramdisk action for postgres tests as the one currently used for in-memory tests
  • put GOTMPDIR on a ramdisk on Windows
  • tune the number of tests running in parallel on macOS and Windows
  • use a ramdisk for postgres on macOS
  • turn off Spotlight indexing on macOS
  • rerun failing tests to stop flakes from disrupting developers

Results:

This PR helps unblock#15109.

@hugodutkahugodutka changed the titlechore: tune postgres CI tests on macOS and Windowschore: tune postgres CI testsMay 11, 2025
@hugodutkahugodutkaforce-pushed thehugodutka/ci-windows-macos-tuning branch 2 times, most recently fromdf428bc to0259ec5CompareMay 12, 2025 07:42
@hugodutkahugodutka marked this pull request as ready for reviewMay 12, 2025 08:23
@@ -12,8 +12,7 @@ permissions:

jobs:
test-go-pg:
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'windows-latest-16-cores' || matrix.os }}
if: github.ref == 'refs/heads/main'
runs-on: ${{ matrix.os == 'macos-latest' && github.repository_owner == 'coder' && 'depot-macos-latest' || matrix.os == 'windows-2022' && github.repository_owner == 'coder' && 'depot-windows-2022-16' || matrix.os }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you add a comment here about the constants you have below for parallelism? It'd be easy for these to go out of sync.

hugodutka reacted with thumbs up emoji
@hugodutkahugodutkaforce-pushed thehugodutka/ci-windows-macos-tuning branch from0259ec5 to8ba05eaCompareMay 12, 2025 15:25
@hugodutkahugodutka merged commitea2cae0 intomainMay 12, 2025
37 checks passed
@hugodutkahugodutka deleted the hugodutka/ci-windows-macos-tuning branchMay 12, 2025 15:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@deansheatherdeansheatherdeansheather approved these changes

Assignees

@hugodutkahugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugodutka@deansheather

[8]ページ先頭

©2009-2025 Movatter.jp