Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(agent): fix unexpanded devcontainer paths for agentcontainers#17736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedMay 9, 2025•
edited
Loading

I noticed devcontainers were duplicated in the API because paths weren't absolute, so now we normalize them early on to keep it simple.

Updates#16424

Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me! Maybe we could have an extra test so we don't have a regression of this in the future

@mafredrimafredriforce-pushed themafredri/fix-agent-agentcontainers-expandpath-bug branch fromedc0731 to9753283CompareMay 9, 2025 11:34
@mafredri
Copy link
MemberAuthor

Looks good to me! Maybe we could have an extra test so we don't have a regression of this in the future

Good idea, updated the existing test to require expansion 👍🏻. It does rely on precedence of operations inexpandPathToAbs (e.g.$HOME before/etc/passwd) which may be a bit brittle, but if that functionality changes we may have other problems too 😄.

@mafredrimafredri merged commit7af188b intomainMay 12, 2025
34 checks passed
@mafredrimafredri deleted the mafredri/fix-agent-agentcontainers-expandpath-bug branchMay 12, 2025 11:03
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 12, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mafredri@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp