- Notifications
You must be signed in to change notification settings - Fork906
fix: enrich thenotLoggedInMessage error message with the full path to the coder#17715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
github-actionsbot commentedMay 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
cdrci2 added a commit to coder/cla that referenced this pull requestMay 8, 2025
notLoggedInMessage error message with the full path to the codernotLoggedInMessage error message with the full path to the coderexecutableSigned-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
goroutineSigned-off-by: Callum Styan <callumstyan@gmail.com>
fba1720 to364c8bfCompareSigned-off-by: Callum Styan <callumstyan@gmail.com>
f0ssel approved these changesMay 12, 2025
578b9ff intomain 34 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening as a draft for now since I'm not really sure this actually provides any value. We set out toresolve#11505 but for this specific login error, if you are not logged in but any of the CLI arg, env var, or config file values are set for the URL you should instead get the
SignedOutErrorMessagerelated to there not being a login token rather than thisnotLoggedInMessage.So at the moment, it really seems like all we can do is change
codertoos.Executable()which would give the full path to the coder executable just in case it's not already somewhere that is in the users path.