Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: load terraform modules when using dynamic parameters#17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromlilac/load-terraform-modules
May 13, 2025

Conversation

aslilac
Copy link
Member

No description provided.

@aslilacaslilac changed the base branch frommain tolilac/persist-terraform-modulesMay 7, 2025 22:48
@aslilac

This comment was marked as outdated.

Base automatically changed fromlilac/persist-terraform-modules tomainMay 8, 2025 22:13
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we noticed a bug with directories, will re-approve

@aslilacaslilac marked this pull request as ready for reviewMay 13, 2025 20:11
@aslilacaslilacforce-pushed thelilac/load-terraform-modules branch fromdb752ea to8c6fd63CompareMay 13, 2025 20:36
Comment on lines -56 to +63
require.Equal(t, "05d2994c1a50ce573fe2c2b29507e5131ba004d15812d8bb0a46dc732f3211f5", hash)
require.Equal(t, "edcccdd4db68869552542e66bad87a51e2e455a358964912805a32b06123cb5c", hash)
} else {
require.Equal(t, "c219943913051e4637527cd03ae2b7303f6945005a262cdd420f9c2af490d572", hash)
require.Equal(t, "67027a27452d60ce2799fcfd70329c185f9aee7115b0944e3aa00b4776be9d92", hash)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great 👍. We need consistent hashes to reuse the same modules files on the backend

@EmyrkEmyrk merged commit60762d4 intomainMay 13, 2025
34 checks passed
@EmyrkEmyrk deleted the lilac/load-terraform-modules branchMay 13, 2025 21:07
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@aslilac@Emyrk

[8]ページ先頭

©2009-2025 Movatter.jp