Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: create ssh directory if it doesn't already exist when runningcoder config-ssh#17711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

brettkolodny
Copy link
Contributor

Closescoder/internal#623

Warning

PR co-authored by Claude Code

@brettkolodnybrettkolodny marked this pull request as ready for reviewMay 8, 2025 13:33
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. In terms of UX, I'm just wondering if we should ask the user first if it is ok to create the.ssh directory 🤔, but not a big deal tho.

@brettkolodny
Copy link
ContributorAuthor

Good point! I think it's fine because running the command already has this prompt though
CleanShot 2025-05-08 at 10 06 35

@brettkolodnybrettkolodny merged commitc5c3a54 intomainMay 8, 2025
36 checks passed
@brettkolodnybrettkolodny deleted the brett-i623/fix-create-ssh-dir-if-not-exist branchMay 8, 2025 14:10
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@brettkolodnybrettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: create .ssh folder if it does not exist already when runningcoder config-ssh
2 participants
@brettkolodny@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp