- Notifications
You must be signed in to change notification settings - Fork1.1k
fix: resolve flake test on manager#17702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
d18fbfe work on flake manager
defelmnqad49aea Merge branch 'main' into internal-544
defelmnq510ffbb add test to trigger race
mafredriab8560d work on flake manager
defelmnq6d4ea2f Merge branch 'main' into internal-544
mafredri2f86f81 refactor notifier close using mutex for Run/Close sync
mafredri869782b s/Info/Debug/ logs
mafredri3dd3174 wait medium
mafredriFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
NextNext commit
work on flake manager
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd18fbfe5b95917cbce7bb08d25c5b06248cd2a8a
There are no files selected for viewing
4 changes: 2 additions & 2 deletionscoderd/notifications/manager.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.