Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: improve variable names of mocked users#17701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 3 commits intomainfrombq/chore-mocks
May 8, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

Many times I got confused when using MockUser and MockUser2 so I just decided to better naming them to MockUserOwner and MockUserMember.

@BrunoQuaresmaBrunoQuaresma requested a review froma teamMay 7, 2025 12:42
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 7, 2025
@BrunoQuaresmaBrunoQuaresma requested review froma team,Kira-Pilot andaslilac and removed request fora team andKira-PilotMay 7, 2025 12:42
@BrunoQuaresmaBrunoQuaresma changed the titlechore: better represent user mockschore: improve representation of user mocksMay 7, 2025
@BrunoQuaresmaBrunoQuaresma changed the titlechore: improve representation of user mockschore: improve user mock namesMay 7, 2025
Copy link
Member

@aslilacaslilac left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

can you update the pr title? it made me think you had changed the name properties (likeMockUser.name)

maybe something like "improve variable names of mocked users"

@BrunoQuaresmaBrunoQuaresma changed the titlechore: improve user mock nameschore: improve variable names of mocked usersMay 8, 2025
@BrunoQuaresmaBrunoQuaresma merged commit2695f4e intomainMay 8, 2025
32 of 33 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/chore-mocks branchMay 8, 2025 12:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BrunoQuaresma@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp