Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore!: fix workspace apps response#17700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 1 commit intomainfrombq/fix-workspaceapps-response
May 7, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma commentedMay 7, 2025•
edited by ethanndickson
Loading

Fix WorkspaceApp response type to better reflect the schema fromhttps://registry.terraform.io/providers/coder/coder/latest/docs/resources/app.

EDIT(ethanndickson): This is a breaking change as it addsomitempty to multiple fields in acodersdk response type. API consumers that expect those fields to be always present may need to be updated.

@BrunoQuaresmaBrunoQuaresma requested review froma teamMay 7, 2025 12:25
@BrunoQuaresmaBrunoQuaresma self-assigned thisMay 7, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromjaaydenh and removed request fora teamMay 7, 2025 12:25
@BrunoQuaresmaBrunoQuaresma requested review fromammario and removed request fora teamMay 7, 2025 12:25
cdr-bot[bot]
cdr-botbot approved these changesMay 7, 2025
Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresmaBrunoQuaresma requested review froma team andEmyrk and removed request forammario anda teamMay 7, 2025 12:25
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wait a sec, isn't it API breaking change?

@BrunoQuaresma
Copy link
CollaboratorAuthor

I'm not sure since it was a "bug"...

@BrunoQuaresmaBrunoQuaresma requested a review frommtojekMay 7, 2025 12:35
@mtojek
Copy link
Member

Hm.. can you link the real issue reported?

@BrunoQuaresma
Copy link
CollaboratorAuthor

Hm.. can you link the real issue reported?

There is no issue. It is just an ad-hoc improvement that would make our FE code more reliable since the types are now truly representing the API response.

@BrunoQuaresmaBrunoQuaresma changed the titlechore: fix workspace apps responsechore!: fix workspace apps responseMay 7, 2025
@github-actionsgithub-actionsbot added the release/breakingThis label is applied to PRs to detect breaking changes as part of the release process labelMay 7, 2025
@BrunoQuaresmaBrunoQuaresma merged commit9fe5b71 intomainMay 7, 2025
38 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/fix-workspaceapps-response branchMay 7, 2025 13:05
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 7, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

@jaaydenhjaaydenhAwaiting requested review from jaaydenhjaaydenh was automatically assigned from coder/ts

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
release/breakingThis label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@BrunoQuaresma@mtojek@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp