- Notifications
You must be signed in to change notification settings - Fork906
refactor: update app buttons to use the new button component#17684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| {children} | ||
| </Button> | ||
| ); | ||
| return <Button variant="outline" ref={ref} {...props} />; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is purpose of keeping AgentButton around instead of removing it and using Button directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a good question.
Since we want to have the TerminalLink, AppLink, VSCode buttons, etc. visually consistent, and be sure they are always looking the same, I just decided to keep the AgentButton. Of course, we could just set the variant in all these components, but since they are many (around 5 or 6 I guess) it would be easy to forget to update one of them when changing some of the styles (maybe it is not a problem since we have tests).
I'm going to refactor the apps logic very soon, so If I see it is just ok to remove the AgentButton, I will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall, straightforward and looks good. Just had a question about the reason to keep AgentButton.tsx
I like the bigger icons. ❤️ |
4fa9d30 intomainUh oh!
There was an error while loading.Please reload this page.
Related to#17311
asChildcapability from the Radix componentsBefore:
After:
