Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: update design of External auth section of CreateWorkspacePage#17683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 3 commits intomainfromjaaydenh/external-auth-button-component
May 5, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedMay 5, 2025•
edited
Loading

contributes tocoder/preview#59

Figma:https://www.figma.com/design/SMg6H8VKXnPSkE6h9KPoAD/UX-Presets?node-id=2180-2995&t=RL6ICIf6KUL5YUpB-1

This updates the design of the External authentication section of the create workspace page form for both the existing and the new experimental create workspace pages.

Screenshot 2025-05-05 at 18 15 28

@jaaydenhjaaydenh self-assigned thisMay 5, 2025
@jaaydenhjaaydenh changed the titlechore: update design of External authchore: update design of External auth section of CreateWorkspacePageMay 5, 2025
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it looks ok, but I have a few design considerations:

  • The list items in the design don't have a space
  • The "Authenticated" text should be xs to match the same text size in the button. I think it makes the things more balanced
  • I think "Authenticate" for the button label should be enough since the item already has the provider name

PS: These are just considerations and not blockers, so I'm going to approve them 👍

@jaaydenh
Copy link
ContributorAuthor

@BrunoQuaresma
"The list items in the design don't have a space" - To match the design the best method would have been to change the ExternalAuthButton into a table. I didn't want to include that much refactoring in this PR.

Regarding using "Authenticate" for the button. I want to avoid using non-standard language unless it really seems better. "Login with Github" is much more common terminology and what most people should be used to.

@jaaydenhjaaydenh merged commit4587082 intomainMay 5, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/external-auth-button-component branchMay 5, 2025 21:13
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@BrunoQuaresma
[8]ページ先頭
©2009-2025 Movatter.jp