Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add experimental Chat UI#17650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 1 commit intomainfromcj/rebase/chat-ui
May 13, 2025
Merged

feat: add experimental Chat UI#17650

johnstcn merged 1 commit intomainfromcj/rebase/chat-ui
May 13, 2025

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedMay 1, 2025
edited
Loading

Builds on#17570

Frontend portion ofhttps://github.com/coder/coder/tree/chat originally authored by@kylecarbs

Additional changes:

  • Addresses linter complaints
  • BringsChatToolInvocation argument definitions in line with those defined incodersdk/toolsdk
  • Ensures chat-related features are not shown unlessExperimentAgenticChat is enabled.

@johnstcnjohnstcn self-assigned thisMay 1, 2025
@johnstcnjohnstcn changed the titleCj/rebase/chat UIwip: rebase chat UIMay 1, 2025
@johnstcnjohnstcnforce-pushed thecj/rebase/chat-ui branch 2 times, most recently from9cc72d3 toe7559c3CompareMay 2, 2025 12:02
@johnstcnjohnstcnforce-pushed thecj/rebase/chat branch 2 times, most recently froma7d6a2f to54a20dbCompareMay 2, 2025 13:47
@johnstcnjohnstcnforce-pushed thecj/rebase/chat-ui branch 2 times, most recently from6a805f9 toae9fbc0CompareMay 2, 2025 16:12
Base automatically changed fromcj/rebase/chat tomainMay 2, 2025 16:29
@johnstcnjohnstcn changed the titlewip: rebase chat UIfeat(site): add chat UIMay 2, 2025
@johnstcnjohnstcn requested a review fromkylecarbsMay 2, 2025 17:31
@johnstcnjohnstcn marked this pull request as ready for reviewMay 2, 2025 17:31
@johnstcnjohnstcn changed the titlefeat(site): add chat UIfeat: add experimental Chat UIMay 2, 2025
Comment on lines 49 to 50
args: unknown;
result?: unknown;
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review: changed tounknown to avoidany

@@ -717,11 +708,12 @@ const FilePreview: FC<{ files: Record<string, string>; prefix?: string }> =
);
});

// TODO: generate these from codersdk/toolsdk.go.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review: ideally these would be autogenerated, but deferring this for now

kylecarbs reacted with thumbs up emoji
Comment on lines +27 to +32
export interface ChatContext {
selectedModel: string;
modelConfig: LanguageModelConfig;

setSelectedModel: (model: string) => void;
}
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

review: Ideally I'd like to move this intouseAgenticChat but ran out of time.

@johnstcnjohnstcnforce-pushed thecj/rebase/chat-ui branch 2 times, most recently fromcb80800 toe29b101CompareMay 12, 2025 12:02
Copy link
Collaborator

@BrunoQuaresmaBrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall, it is ok and I didn't find anything that could cause major bugs or bad user experiences. However, we are not following some FE agreements we did like using the new shadcn components, TailwindCSS for styles, or Lucide icons.

I also think the design is not the best when dealing with error handling and loading states. We probably could make a better use of design work here to be honest, but I'm not sure how urgent this release is.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would move this file tosites/src/modules/chat/useAgenticChat.ts.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Even though it's imported inmodules/dashboard/NavBar/NavbarView?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeap! I think it makes more sense. But no strong thoughts, you can leave as it is if it makes more sense to you.

johnstcn reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm going to leave it where it is for now; I think there's more scope to refactor here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not sure if this should be included in the scope of this PR, but all the new pages and components are made using shadcn/ui components, TailwindCSS styles, and Lucide icons as part of our redesign effort.

@johnstcnjohnstcnforce-pushed thecj/rebase/chat-ui branch 2 times, most recently from5fb99bd to5f2536fCompareMay 13, 2025 15:59
Builds on#17570Frontend portion ofhttps://github.com/coder/coder/tree/chat originallyauthored by@kylecarbsAdditional changes:- Addresses linter complaints- Brings `ChatToolInvocation` argument definitions in line with thosedefined in `codersdk/toolsdk`- Ensures chat-related features are not shown unless`ExperimentAgenticChat` is enabled.Co-authored-by: Kyle Carberry <kyle@carberry.com>
@johnstcnjohnstcn merged commita1c03b6 intomainMay 13, 2025
33 of 34 checks passed
@johnstcnjohnstcn deleted the cj/rebase/chat-ui branchMay 13, 2025 16:24
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 13, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@BrunoQuaresmaBrunoQuaresmaBrunoQuaresma approved these changes

@kylecarbskylecarbskylecarbs approved these changes

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@BrunoQuaresma@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp