NotificationsYou must be signed in to change notification settings
Fork905
Star10k

fix: improve WebSocket error handling in CreateWorkspacePageExperimental#17647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jaaydenh merged 1 commit intomainfromjaaydenh/websocket-strict-mode

May 1, 2025

Merged

fix: improve WebSocket error handling in CreateWorkspacePageExperimental#17647

jaaydenh merged 1 commit intomainfromjaaydenh/websocket-strict-mode

May 1, 2025

Conversation

Copy link

Contributor

jaaydenh commentedMay 1, 2025•
edited
Loading

Refactor WebSocket error handling to ensure that errors are only set when the current socket ref matches the active one. This prevents unnecessary error messages when the WebSocket connection closes unexpectedly

This solves the problem of showing error messages because of React Strict mode rendering the page twice and opening 2 websocket connections.

fix: improve WebSocket error handling in CreateWorkspacePageExperimental

f65fd57

Refactor WebSocket error handling to ensure that errors are only set when the current socket matches the active one. This prevents unnecessary error messages when the WebSocket connection closes unexpectedly