- Notifications
You must be signed in to change notification settings - Fork907
fix(codersdk/toolsdk): ensure all tools include required fields of aisdk.Schema#17632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR adds validation tests for the AISDK Schema in all tools and ensures that each tool’s schema includes the required "Properties" and "Required" fields.
- Added a new test (TestToolSchemaFields) in toolsdk_test.go to validate that all tools have non-nil Schema.Properties and Schema.Required, and that each required field has a corresponding property.
- Updated toolsdk.go for the ListWorkspaces and DeleteTemplate tools to include or enforce the Required fields as part of the tool schema.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| codersdk/toolsdk/toolsdk_test.go | Added tests to verify that each tool contains the required Schema fields. |
| codersdk/toolsdk/toolsdk.go | Updated tool definitions to include the "Required" field in the schema. |
Uh oh!
There was an error while loading.Please reload this page.
4ac71e9 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.