Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix data race in agentscripts.Runner#17630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedMay 1, 2025
edited
Loading

Fixescoder/internal#604

Fixes a data race inagentscripts.Runner where a concurrentExecute() call races withInit(). We hit this race during shut down, which is not synchronized against starting up.

In this PR I've chosen to add synchronization to theRunner rather than try to synchronize the calls in the agent. When we close down the agent, it's OK to just throw an error if we were never initialized with a startup script---we don't want to wait for it since that requires an active connection to the control plane.

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewMay 1, 2025 09:51
@spikecurtisspikecurtis merged commitef00ae5 intomainMay 1, 2025
36 checks passed
@spikecurtisspikecurtis deleted the spike/internal-604-agentscriptrunner-race branchMay 1, 2025 10:25
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake:TestAgent_ImmediateClose
2 participants
@spikecurtis@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp