Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: create directory before writing coder connect network info file#17628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanndickson merged 1 commit intomainfromethan/mkdir-all-coder-connect-ssh
May 1, 2025

Conversation

ethanndickson
Copy link
Member

@ethanndicksonethanndickson commentedMay 1, 2025•
edited
Loading

The regular network info file creation code also callsMkdirall.

Wasn't picked up in manual testing as I already had the/net folder in my VSCode.

Wasn't picked up in automated testing because we use an in-memory FS, which for some reason does this implicitly:

func (m *MemMapFs) registerWithParent(f *mem.FileData, perm os.FileMode) {if f == nil {return}parent := m.findParent(f)if parent == nil {pdir := filepath.Dir(filepath.Clean(f.Name()))err := m.lockfreeMkdir(pdir, perm)[...]

@ethanndicksonGraphite App
Copy link
MemberAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@ethanndicksonethanndickson changed the titlefix(cli/ssh): mkdirall before writing coder connect network info filefix(cli): mkdirall before writing coder connect network info fileMay 1, 2025
@ethanndicksonethanndickson changed the titlefix(cli): mkdirall before writing coder connect network info filefix: mkdirall before writing coder connect network info fileMay 1, 2025
@ethanndicksonethanndickson changed the titlefix: mkdirall before writing coder connect network info filefix: create directory before writing coder connect network info fileMay 1, 2025
@ethanndicksonethanndickson marked this pull request as ready for reviewMay 1, 2025 06:31
cdr-bot[bot]
cdr-botbot approved these changesMay 1, 2025
Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndicksonethanndicksonenabled auto-merge (squash)May 1, 2025 06:31
@ethanndicksonethanndickson merged commitc7fc7b9 intomainMay 1, 2025
50 checks passed
@ethanndicksonethanndickson deleted the ethan/mkdir-all-coder-connect-ssh branchMay 1, 2025 06:53
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

Assignees

@ethanndicksonethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp