Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: fix for prebuilds claiming and deletion#17624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 8 commits intomainfromyevhenii/prebuilds-minor-fix
May 1, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina commentedApr 30, 2025
edited by dannykopping
Loading

PR contains:

  • fix for claiming & deleting prebuilds with immutable params
  • unit test for claiming scenario
  • unit test for deletion scenario

The parameter resolver was failing when deleting/claiming prebuilds because a value for a previously-used parameter was provided to the resolver, but since the value was unchanged (it's coming from the preset) it failed in the resolver. The resolver was missing a check to see if the old value != new value; if the values match then there's no mutation of an immutable parameter.

@evgeniy-scherbinaevgeniy-scherbina marked this pull request as ready for reviewApril 30, 2025 21:38
…ationSigned-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykoppingenabled auto-merge (squash)May 1, 2025 08:39
@dannykoppingdannykopping merged commit98e5611 intomainMay 1, 2025
29 checks passed
@dannykoppingdannykopping deleted the yevhenii/prebuilds-minor-fix branchMay 1, 2025 08:52
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsMay 1, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@SasSwartSasSwartSasSwart approved these changes

@dannykoppingdannykoppingAwaiting requested review from dannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@evgeniy-scherbina@dannykopping@SasSwart

[8]ページ先頭

©2009-2025 Movatter.jp