- Notifications
You must be signed in to change notification settings - Fork905
fix: update default value handling for dynamic defaults#17609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| const selectedOptions: Option[] = JSON.parse(value).map((val: string) => { | ||
| const option = parameter.options.find((o) => o.value.value === val); | ||
| return { | ||
| value: val, | ||
| label: option?.name || val, | ||
| disable: false, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is screaming for some sort of typing issue here. how confident are we thatJSON.parse(value) will actually always return astring[] here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Improved
c3d08ef tof61fd0aCompareec003b7 intomainUh oh!
There was an error while loading.Please reload this page.
resolvescoder/preview#102