- Notifications
You must be signed in to change notification settings - Fork1k
chore: remove circular dependencies#17585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
site/src/hooks/index.ts Outdated
| export*from"./useClickableTableRow"; | ||
| export*from"./useClipboard"; | ||
| export*from"./usePagination"; | ||
| export*from"./useAuthenticated"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
alphabetize pls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this context needs to stay colocated where it was so that we actually remember to delete it when the feature is done
b6146df intomainUh oh!
There was an error while loading.Please reload this page.
I've been bit in the past by hard to deduce bugs caused by circular dependencies within TS projects. On a hunch that this could be contributing to some flaky tests I've used the tooldpdm to find and remove them.
This PR does the following:
check:circular-depencypnpm script