Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix prebuild omissions#17579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 2 commits intomainfromdk/prebuilds-hotfix
Apr 30, 2025
Merged

fix: fix prebuild omissions#17579

dannykopping merged 2 commits intomainfromdk/prebuilds-hotfix
Apr 30, 2025

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedApr 28, 2025•
edited
Loading

0a3e9a9 was an accidental omission from#17527

@dannykoppingdannykopping changed the titlefix: address prebuild omissionsfix: fix prebuild omissionsApr 28, 2025
@dannykopping
Copy link
ContributorAuthor

I hate grammar-bot.

Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but we may consider to add test where we add/delete prebuild user to/from a group

Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykopping
Copy link
ContributorAuthor

LGTM, but we may consider to add test where we add/delete prebuild user to/from a group

Good point; I'm gonna split that out into its own PR.

Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykopping marked this pull request as ready for reviewApril 30, 2025 14:16
@dannykoppingdannykoppingenabled auto-merge (squash)April 30, 2025 14:17
@dannykoppingdannykopping merged commit6936a7b intomainApr 30, 2025
33 checks passed
@dannykoppingdannykopping deleted the dk/prebuilds-hotfix branchApril 30, 2025 14:26
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@evgeniy-scherbinaevgeniy-scherbinaevgeniy-scherbina approved these changes

@SasSwartSasSwartAwaiting requested review from SasSwart

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@dannykopping@evgeniy-scherbina
[8]ページ先頭
©2009-2025 Movatter.jp