- Notifications
You must be signed in to change notification settings - Fork1k
feat(agent/agentcontainers): add file watcher and dirty status#17573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
23 commits Select commitHold shift + click to select a range
40c8de9
feat(agent/agentcontainers): add file watcher and dirty status
mafredria997f82
make gen
mafredri0e568fb
fix copilot nits
mafredri4f788d9
log event string in case not write
mafredribfeb1da
fix chmod on macos
mafredri45a978c
fix close of closed channel
mafredrid2721a7
add close protection to fsnotify watcher as well
mafredric03bb7d
fix typo
mafredriaed7c30
fix pr suggestions and improve start loop
mafredri39526e6
update noop impl.
mafredri7edee90
s/file/path
mafredri9cf5415
rewrite watcher impl. to watch dirs
mafredride2a42e
add rename and create to fsnotify test
mafredri0cbee38
add atomic file replacement
mafredri5ced7e1
add paranoid reset
mafredri5a96a55
fix oopsie
mafredri0b16448
s/ErrWatcherClosed/ErrClosed/g
mafredrieaf5922
inverse continue/return for clarity
mafredri617fed2
better close handling
mafredri8ee9914
restore removed comment
mafredri263c683
add note about name
mafredri58a70e8
fix test setup/clock advancement
mafredri9f739ca
outdent
mafredriFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
fix typo
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitc03bb7d74715de56a216c5a0a103d7bcf6ba50d1
There are no files selected for viewing
6 changes: 4 additions & 2 deletionsagent/agentcontainers/watcher/noop.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.